New Keyboard Shortcuts

[ndom91]

We're looking for input on some more keyboard shortcuts. We want to align with other similar apps and implement keyboard shortcuts that will be familiar to users. We're currently considering adding the following:

• [ ] ctrl + a to select all files in filelist in commit mode
• [ ] space to toggle select/unselect on focused file
• [ ] esc to close an opened file diff preview
• [ ] ctrl + ? to open a keyboard shortcut overview menu

Also potentially ctrl + z/y to travel back and forth in the oplog aka undo stack.

Please add any other ideas below :grin:

[freak4pc]

Just wanted to report that using up/down keys to navigate between files doesn't work - not sure if it's planned to not work or it's a bug, but that's the behavior in other Git UI tools :)

[ndom91]

Thanks for chiming in! Yeah those sound sensible as well 👌

[PavelLaptev]

Just wanted to report that using the up/down keys to navigate between files doesn't work. Not sure if it's intentional or a bug, but that's how it works in other Git UI tools. :)

@freak4pc This is indeed a bug. The functionality should be working, so I'm wondering why it isn't on your end. If possible, could you please create a separate issue for this? You can do so using this link.

https://github.com/user-attachments/assets/cefe35bc-d6ca-43d6-8ba1-cf8233a08217

[freak4pc]

Just wanted to report that using the up/down keys to navigate between files doesn't work. Not sure if it's intentional or a bug, but that's how it works in other Git UI tools. :)

@freak4pc This is indeed a bug. The functionality should be working, so I'm wondering why it isn't on your end. If possible, could you please create a separate issue for this? You can do so using this link.

Screen.Recording.2024-08-26.at.15.22.52.mov

Thanks, I actually meant when being focused on a specific commit, not on the staged workspace changes

[PavelLaptev]

Thanks, I actually meant when being focused on a specific commit, not on the staged workspace changes

@freak4pc, thank you for clarifying this. Yes, it doesn’t work at the moment. It's something we need to fix.

[H1ghBre4k3r]

I am currently thinking if hitting esc while in the settings (both, project and app settings) should bring you back to the previous screen from where you opened the settings (similar to the small arrow on the upper left hand side).

[ndom91]

I am currently thinking if hitting esc while in the settings (both, project and app settings) should bring you back to the previous screen from where you opened the settings (similar to the small arrow on the upper left hand side).

I find myself hitting esc to do just that out of muscle memory sometimes :sweat_smile: Down with this as well!

[ndom91]

Note for ourselves for the future: Navigating up/down with the keyboard arrows in the Filelist sometimes behaves very strangely. For example, skipping items, stopping at "incorrect" items, etc.

[PavelLaptev]

Note for ourselves for the future: Navigating up/down with the keyboard arrows in the Filelist sometimes behaves very strangely. For example, skipping items, stopping at "incorrect" items, etc.

Can you please also attach a video capture or describe how to reproduce this.

[ndom91]

There's not much to record, for example in this scenario:

If I select the top file, controller.js, I can only navigate down to index.js with the keyboard down arrow. Then it gets stuck.

Similarly, if I click on the bottom item, test.txt, and press up on the keyboard arrow, it jumps to index.js (skipping package.json) and then gets stuck on index.js.