gitbutlerapp / gitbutler

The GitButler version control client, backed by Git, powered by Tauri/Rust/Svelte
https://gitbutler.com
Other
12.61k stars 499 forks source link

Drag'n'drop tp branch should also work with title #4787

Open koppor opened 1 month ago

koppor commented 1 month ago

Version

0.12.16

Operating System

Windows

Distribution Method

msi (Windows)

Describe the issue

Changes can be dropped to virtual branches. As drop target, only the file list is possible. But the header should also be a drop target. The change should be added to changed files, too.

How to reproduce

image

Expected behavior

Change should be added to changed files.

Relevant log output

No response

Byron commented 1 month ago

Thanks for letting us know!

Hi @PavelLaptev , I thought his one might be interesting for you.

Personally I tried it and found it understandable not to be able to drop files off outside the box, and to me it would be unexpected to accept a drop on the title which I'd use to last-minute cancel the drop.

koppor commented 1 month ago

Thank you for the answer. I need to read where I drop and I target that text. Similar to darts, where the target areas are marked and I need to hit them. Different to bins where the bin is labeled with the contents, but I need to hit the bin, not the label.

PavelLaptev commented 1 month ago

I believe the top of the lane should not have a drop area, or at least it shouldn't be visible.

Each lane can have multiple drop zones for files, and it's important to clearly distinguish them because they trigger different actions.

When you have a PR the lane header will be separated from the "changed files" section with a "PR" card, so in this case there will be two drop zones that duplicate the same action, which could lead to confusion → header to drop files then not droppable PR card then the droppable "changed files" section again (see image below). Also, drop zones have this overlay color when they're active, I would like to leave the lane header clean and visible without a drop capability.

image