Signing commits with Credit GitButler is "broken" - Githubissues

gitbutlerapp / gitbutler

The GitButler version control client, backed by Git, powered by Tauri/Rust/Svelte

https://gitbutler.com

Other

13.19k stars 523 forks source link

Signing commits with Credit GitButler is "broken" #5439

Open GordonBeeming opened 1 day ago

GordonBeeming commented 1 day ago

Version

Version 0.13.9 (20241105.001935)

Operating System

macOS

Distribution Method

dmg (Apple Silicon)

Describe the issue

If I try to sign a commit and also have credit GitButler on, then GitHub reports the commit as unverified

How to reproduce

Use signed commits (mine goes through 1 Password) and have credit gitbutler on This would lead to an unverified commit in GitHub

I made a short video showing this to make it easy to reproduce https://www.youtube.com/watch?v=xpgJAtURiuk (2 min)

Expected behavior

The commit should ideally show as verified in GitHub
OR the app should not credit when signing to keep the verified commit status

Relevant log output

No response

Byron commented 1 day ago

Thanks a lot for reporting, and for the wonderfully produced video! That's a first in my 15 years worth of open source experience as well 🎉.

Regarding the issue, you are right in thinking that there is no way to sign correctly when crediting GItButler, as the signature is bound to the email address known to GitHub (effectively). So it seems the UI has to account for that in some way. CC @PavelLaptev who knows how to get the best UX here.