gitcoinco / code_fund_ads

CodeFund is an open source platform that helps fund maintainers, bloggers, and builders through non-tracking ethical ads
https://codefund.io
GNU Affero General Public License v3.0
375 stars 104 forks source link

fix: stop total budget from updating when daily budget is changed #1305

Closed andrewmcodes closed 4 years ago

andrewmcodes commented 4 years ago

Type of PR

Description

Changing the daily budget on bundled campaigns was dynamically updating the total budget, which we don't want.

Checklist

Screenshots

codecov[bot] commented 4 years ago

Codecov Report

Merging #1305 into master will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
- Coverage   34.53%   34.51%   -0.02%     
==========================================
  Files         344      344              
  Lines        7955     7952       -3     
==========================================
- Hits         2747     2745       -2     
+ Misses       5208     5207       -1     
Impacted Files Coverage Δ
app/models/concerns/campaigns/budgetable.rb 70.45% <100.00%> (+0.12%) :arrow_up: