gitcoinco / code_fund_ads

CodeFund is an open source platform that helps fund maintainers, bloggers, and builders through non-tracking ethical ads
https://codefund.io
GNU Affero General Public License v3.0
375 stars 104 forks source link

Add campaign validation to ensure creatives are attached #1314

Closed andrewmcodes closed 4 years ago

andrewmcodes commented 4 years ago

Type of PR

Description

Make sure campaigns cannot be saved without creatives attached.

Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #1314 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1314   +/-   ##
=======================================
  Coverage   34.76%   34.76%           
=======================================
  Files         345      345           
  Lines        7989     7989           
=======================================
  Hits         2777     2777           
  Misses       5212     5212           
Impacted Files Coverage Δ
app/models/campaign.rb 79.08% <100.00%> (ø)
app/jobs/schedule_organization_report_job.rb 86.20% <0.00%> (ø)