gitcoinco / code_fund_ads

CodeFund is an open source platform that helps fund maintainers, bloggers, and builders through non-tracking ethical ads
https://codefund.io
GNU Affero General Public License v3.0
375 stars 104 forks source link

Exit email attachment iteration unless image with content_id is present #1317

Closed andrewmcodes closed 4 years ago

andrewmcodes commented 4 years ago

Type of PR

Description

Stop calling replace on nil when document.at_css "img[src='cid:#{content_id}']" is not found while iterating through incoming email attachments

Fixes #1316

Checklist

Screenshots

codecov[bot] commented 4 years ago

Codecov Report

Merging #1317 into master will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   34.76%   34.75%   -0.01%     
==========================================
  Files         345      345              
  Lines        7989     7990       +1     
==========================================
  Hits         2777     2777              
- Misses       5212     5213       +1     
Impacted Files Coverage Δ
app/mailboxes/incoming_mailbox.rb 64.28% <0.00%> (-1.57%) :arrow_down: