gitcoinco / code_fund_ads

CodeFund is an open source platform that helps fund maintainers, bloggers, and builders through non-tracking ethical ads
https://codefund.io
GNU Affero General Public License v3.0
375 stars 104 forks source link

Stop exceptions from raising when email has already been created #1321

Closed andrewmcodes closed 4 years ago

andrewmcodes commented 4 years ago

Type of PR

Description

We do not need to raise exceptions when emails cannot be created. This change also stops read marks from recording when a user is masquerading.

Fixes #1320

Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #1321 into master will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1321   +/-   ##
=======================================
  Coverage   34.75%   34.75%           
=======================================
  Files         345      345           
  Lines        7990     7990           
=======================================
  Hits         2777     2777           
  Misses       5213     5213           
Impacted Files Coverage Δ
app/controllers/emails_controller.rb 0.00% <0.00%> (ø)
app/mailboxes/incoming_mailbox.rb 64.28% <100.00%> (ø)
app/jobs/schedule_organization_report_job.rb 86.20% <0.00%> (ø)