gitcoinco / easy-retro-pgf

Retroactive Public Goods Funding for everyone.
https://easyretropgf.xyz
MIT License
54 stars 30 forks source link

fix hasVoted query #130

Closed thelostone-mc closed 2 weeks ago

thelostone-mc commented 2 weeks ago

Currently we use ballotV2. signature to see if a person has voted but this is not right the UI doesn't ask for a signature if the user has already signed for a previous round. This causes confusion where if you have voted on round 1 , it shows up as you've voted in any other round.

This updates the check to rely on allocations table which is accurate and filter by round

http://localhost:3000/test-round/admin/voters

Before:

Screenshot 2024-08-28 at 3 49 23 PM

After:

image
vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
easy-retro-pgf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 10:24am
ezrf-impact ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 10:24am
linear[bot] commented 2 weeks ago

PAR-292 ensure voted flag show up correctly on admin/voters