search

gitcoinco / gitcoin-erc721

11 stars 3 forks source link

resale terms for kudos #159

Open owocki opened 6 years ago

owocki commented 6 years ago

add an element to the Kudos struct the tells the user what the ressale terms are

resale terms examples:

owocki commented 6 years ago

@jasonrhaas this is an idea from ETHSF -- it is not a priority now (unless its a very easy lift)..

jasonrhaas commented 6 years ago

Is this kind of a like a "Terms & Conditions" paragraph? If its something boilerplate that doesn't need to be mutable on the contract, I can put it in the metadata and store it off chain (save some gas).

owocki commented 6 years ago

the only reason for onchain vs IPFS, i was thinking that it would have to be onchain is so that we could add require(is_transferrable) or similar to the transefer() functions

jasonrhaas commented 6 years ago

So we want to make some of the kudos non-transferable? I think that goes against the base implementation in Open Zeppelin. Also it may not work with Open Sea in that case, they rely on the "standard" ERC721 implementation I believe. We can do it still, just something to consider.

I did mention this idea a couple weeks ago (about non-transferability), and I don't think @PixelantDesign was on board with the idea. I just want to make sure we are on the same page.

https://ethereum.stackexchange.com/questions/41740/non-transferrable-erc721-token

owocki commented 6 years ago

ok, lets put it on the backburner for now