gitcoinco / grant-hub

Other
20 stars 11 forks source link

Add application error states #332

Open michellema1208 opened 2 years ago

michellema1208 commented 2 years ago

Tasks

error
michellema1208 commented 2 years ago

⚠️ Status Update: Moving back to "In Progress"

hey @codenamejason - I just tested this change, and I see that it's working for most of the form fields, with a few inconsistencies. I found that:

PRIORITY

STYLE UPDATES

Currently in staging: Image

Will's original designs: Image

codenamejason commented 2 years ago

@michellema1208 the label for the wallet address comes from round-manager and if round-manager doesn't send one we provide the value label={input.question ?? "Payout Wallet Address"}. Should we hardcode the "Payout Wallet Address"?

michellema1208 commented 2 years ago

@codenamejason in short, yes! Since we (Grant Hub) are adding the Payout Wallet Address question to the application form every time, we should also be the ones setting the label to "Payout Wallet Address" - we shouldn't be pulling that from the round metadata from round-manager.

I think round-manager having a label for Payout Wallet Address may be something that was never cleaned up after we decided that Grant Hub would always load the Payout Wallet Address question on every application form (for context).

michellema1208 commented 2 years ago

✅ Status: Moving to "Ready for Deployment"

@codenamejason I tested this, and it has addressed the functional errors I shared above. There are some style enhancements I'd like to make, but I will track them and prioritize them in a separate ticket.