Open michellema1208 opened 2 years ago
hey @codenamejason - I just tested this change, and I see that it's working for most of the form fields, with a few inconsistencies. I found that:
PRIORITY
STYLE UPDATES
Currently in staging:
Will's original designs:
@michellema1208 the label for the wallet address comes from round-manager and if round-manager doesn't send one we provide the value label={input.question ?? "Payout Wallet Address"}
. Should we hardcode the "Payout Wallet Address"?
@codenamejason in short, yes! Since we (Grant Hub) are adding the Payout Wallet Address question to the application form every time, we should also be the ones setting the label to "Payout Wallet Address" - we shouldn't be pulling that from the round metadata from round-manager.
I think round-manager having a label for Payout Wallet Address may be something that was never cleaned up after we decided that Grant Hub would always load the Payout Wallet Address question on every application form (for context).
@codenamejason I tested this, and it has addressed the functional errors I shared above. There are some style enhancements I'd like to make, but I will track them and prioritize them in a separate ticket.
Tasks