fix: isInfiniteDate should check if year is lower or equal to 1970

Fixes: #issue https://github.com/gitcoinco/grants-stack/issues/3536

Description

Our data layer is not checking if round dates are null when fetched from the indexer:

getRoundForExplorer() -> packages/data-layer/src/data-layer.ts

Converting null to Date becomes -> 1970-01-01T00:00:00.000Z (timestamp 0 / Computer Dinosaur Age)

That's the main issue, depending on the timezone, it can be greater or lower than that.

One solution would be to convert all dates to UTC and make calculations from there. Another solution would be that the data-layer leave null dates as null or undefined instead of converting it.

We currently have this function to address this issue:

export const isInfiniteDate = (roundTime: Date) => {
  return (
    roundTime.toString() === "Invalid Date" || roundTime.getFullYear() === 1970
  );
};

But it wasn't taking in consideration that the year can become 1969 depending on the Timezone.

Changed the check from === 1970 to <= 1970

const isInfiniteDate = (roundTime: Date) => {
  return (
    roundTime.toString() === "Invalid Date" || roundTime.getFullYear() <= 1970
  );
};

An alternative solution would be:

const isInfiniteDate = (roundTime: Date) => {
  return (
    roundTime.toString() === "Invalid Date" || roundTime.toISOString() === "1970-01-01T00:00:00.000Z"
  );
};

Checklist

This PR:

[ ] Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
[ ] Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
[ ] Doesn't disable eslint rules.
[ ] Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
[ ] Doesn't contain commented out code.
[ ] If adding/updating a feature, it adds/updates its test script on Notion.

Name	Status	Preview	Comments	Updated (UTC)
builder	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 4:45pm
builder-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 4:45pm
explorer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 4:45pm
explorer-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 4:45pm
manager	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 4:45pm
manager-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 4:45pm

gitcoinco / grants-stack

fix: isInfiniteDate should check if year is lower or equal to 1970 #3537

Description

Checklist