gitcoinco / ios

Push Open Source Forward
Other
23 stars 10 forks source link

WIP towards MVP #3

Closed cheneveld closed 6 years ago

cheneveld commented 7 years ago

Next Up:

  1. Skills API request, local persistence, UI to edit, send with bounties request to filter
  2. Hook up Fabric / Mixpanel
  3. Design/Implement Push Notification System
  4. More better UI/UX
owocki commented 7 years ago

👍

cheneveld commented 7 years ago

@owocki the current keyword endpoint is https://gitcoin.co/profile/cheneveld/keywords

This is not behind the "api".

Could we create a route like https://gitcoin.co/api/v0.1/profile/cheneveld/keywords???

cheneveld commented 7 years ago

@owocki Could you have api errors respond with a 500 status code and a json formatted response?

https://gitcoin.co/api/v0.1/bounties/?idx_status=open&order_by=-web3_created&pk__gt=

owocki commented 7 years ago

@owocki Could you have api errors respond with a 500 status code and a json formatted response?

Could we create a route like https://gitcoin.co/api/v0.1/profile/cheneveld/keywords???

just pushed up a fix for both of these

owocki commented 7 years ago

Looks like I'm missing something called 'Mapper'. Does it need to be added to the podfile? http://bits.owocki.com/051m3M0G3i0N/Image%202017-11-09%20at%2011.12.15%20AM.png

cheneveld commented 7 years ago

No you probably opened the "Gitcoin.xcodeproj" file, need to open and use the workspace file "Gitcoin.xcworkspace"

owocki commented 7 years ago

No you probably opened the "Gitcoin.xcodeproj" file, need to open and use the workspace file "Gitcoin.xcworkspace"

hmmm i seem to have a bunch more build issues when i do this => http://bits.owocki.com/3k3W0I2K2m0z/Screen%20Shot%202017-11-09%20at%201.13.32%20PM.png

it's not super urgent for me to get this working; maybe next time we get together we can pair on getting it working

cheneveld commented 7 years ago

k, what version of xcode are you on?

owocki commented 7 years ago

Version 9.1 (9B55)

cheneveld commented 7 years ago

Pull this latest and rerun pod install

cheneveld commented 7 years ago

I think we will need to convert from cocoapods to either Swift Package Manager or Carthage for our dependency management in the future.

I just got some weird behavior with pods.

after I commented out the pod dependencies in the Podfile, ran pod install, uncommented em, then pod install again it started working again.

@owocki perhaps do that if you still have problems.

I think long term is to move away from Cocoapods

owocki commented 7 years ago

it built! i'm in, thanks!

cheneveld commented 6 years ago

@owocki I'm ready to pass the user skills/keywords to the bounty api endpoint via raw_data but seems it only accepts a single string. How can I pass multiple values?

owocki commented 6 years ago

@owocki I'm ready to pass the user skills/keywords to the bounty api endpoint via raw_data but seems it only accepts a single string. How can I pass multiple values?

Just pushed support for comma,delimited,keyword,values. Give it a try now!

owocki commented 6 years ago

heres a sample request from my local:

http://localhost:8080/api/v0.1/bounties/?&raw_data=owocki,piper&idx_status=open&network=mainnet&coinbase=0x4331b095bc38dc3bce0a269682b5ebaefa252929&order_by=-web3_created

note the owocki,piper

cheneveld commented 6 years ago

@owocki can we have another bounty description field that is plain text, removed html, for displaying simply on the bounty cards?

owocki commented 6 years ago

@owocki can we have another bounty description field that is plain text, removed html, for displaying simply on the bounty cards?

sure, itll be called issue_description_text

owocki commented 6 years ago

deploying issue_description_text now

cheneveld commented 6 years ago

@owocki could you clean up the issue_description_text? I think just removing newlines at begining of text and removing when we have 3 or more turn to 2 -> https://screencast.com/t/vbUqdeOo5

Could even make max 1 new line as ios will(can) indent on each new line

owocki commented 6 years ago

@owocki could you clean up the issue_description_text? I think just removing newlines at begining of text and removing when we have 3 or more turn to 2 -> https://screencast.com/t/vbUqdeOo5

sure thing, https://github.com/gitcoinco/web/commit/54e728adf341c6e83b1a8bff2b04115001ed9002 takes care of this

cheneveld commented 6 years ago

Getting down to it.

Next up is more UI and COPY tweaks. Then review TODOs through out app.
Refine tracking.

cheneveld commented 6 years ago

@owocki

Thinking about this project being capable of allowing any developer to get going in xcode right away... as it stands now it is pointing to production by default. Is this ok? or should we get hooked into staging?

Perhaps we hook in with the creds in the project?

Thoughts?

Perhaps flags on the api calls to say that its a debug build and to not send the intro emails?

owocki commented 6 years ago

i think production is fine.

owocki commented 6 years ago

Perhaps flags on the api calls to say that its a debug build and to not send the intro emails?

sure. how about &debug_build=1

cheneveld commented 6 years ago

or how bought pretend=1 ?

owocki commented 6 years ago

works 4 me

owocki commented 6 years ago

i fixed the match emails tongiht http://bits.owocki.com/0u0D0z3v3F3B/Screen%20Shot%202017-12-01%20at%2011.22.01%20PM.png

cheneveld commented 6 years ago

@owocki per Alpha feedback you shouldnt force users to sign in to be able to accumulate some bounties...

How bought we let the user swipe left (-) while signed out. But if a swipe right occurs when the user is logged out we display an alert with some intel on what that action is actually doing. Like "Please sign in to gihub so we can connect you with the repo owner of this bounty".

Also, Everytime you login or logout the lastBountyId is reset (wonder if we can make this obvious some how?). So perhaps we can flash that alert recommend logging in and then allowing the right swipe with after the alert is shown once.

Thoughts?

owocki commented 6 years ago

How bought we let the user swipe left (-) while signed out. But if a swipe right occurs when the user is logged out we display an alert with some intel on what that action is actually doing. Like "Please sign in to gihub so we can connect you with the repo owner of this bounty".

I could go either way on this. Slightly in favor of this.

Also, Everytime you login or logout the lastBountyId is reset (wonder if we can make this obvious some how?). So perhaps we can flash that alert recommend logging in and then allowing the right swipe with after the alert is shown once.

Maybe we could put some copy below the 'sign out' button that says as much.

cheneveld commented 6 years ago

@owocki Could you provide some copy -> https://screencast.com/t/oMZpskyYS6b

cheneveld commented 6 years ago

per

it'd be really cool if we could enumerate the users 1 by 1 and see their attributes (prog languages, num new bounties since last push)… to send a super custom push notification

Now sending pushwoosh user info and events. so we can play with events, auto pushes and such.

owocki commented 6 years ago

@owocki Could you provide some copy -> https://screencast.com/t/oMZpskyYS6b

h1- Sign In with Github p - to get match email intros to this repo owner.

Now sending pushwoosh user info and events. so we can play with events, auto pushes and such.

neat, what user info / events are you sending?

cheneveld commented 6 years ago

Check out this commit -> https://github.com/gitcoinco/ios/pull/3/commits/411dabda5848d4e0edec1a1195dcc7dcb3ef8723

cheneveld commented 6 years ago

@owocki noticed the web app stores keywords?? or looks like it -> https://screencast.com/t/7eXDKOThMeu.

Should we think about having the keywords insync with ios?

owocki commented 6 years ago

Should we think about having the keywords insync with ios?

for 99% of UX, this seems 👍 to me. but i worry that having them in sync with each other would introduce an attack vector wherein a user on their iphone could enter an erroneous email address and update anyone's keywords. i suppose we'd have to have an email address confirmation to close this attack vector.

owocki commented 6 years ago

wait, on second thought... if we use github oauth, by definition, that will always just have a confirmed email address