gitcoinco / ios

Push Open Source Forward
Other
23 stars 10 forks source link

get it live on the app store #31

Closed owocki closed 6 years ago

owocki commented 6 years ago

what

PixelantDesign commented 6 years ago

Yep, that looks right!

john-brunelle commented 6 years ago

k I can add back in the swipe right, however, we will need some API to save the bounty as well as to remove the saved bounty. @owocki can you add that into the API? Or is there something there already pls let em know.

john-brunelle commented 6 years ago

I would also imagine that the saved bounty would need a 'start work' and 'remove' button in the details

owocki commented 6 years ago

k I can add back in the swipe right, however, we will need some API to save the bounty as well as to remove the saved bounty. @owocki can you add that into the API? Or is there something there already pls let em know.

for simplicity, can we please just save the IDs locally instead of storing them server side?

i agree philosophically with having the info server side to maintain UX parity.. but given this is just an MVP to see if anyones even gonna use it, im okay current the corner here

john-brunelle commented 6 years ago

Could do that, I'll need a local database, implement the mapping (id, title, desc.) and crud. Not super quick thing but I can do. There might be some edges to work out but not sure about that yet.

I'll move in this direction if ya rather

john-brunelle commented 6 years ago

one thing to keep in mind is that if the user deletes the app, they will lose the saved

owocki commented 6 years ago

Could do that, I'll need a local database, implement the mapping (id, title, desc.) and crud. Not super quick thing but I can do. There might be some edges to work out but not sure about that yet.

i was under the impression that there'd be some sort of drop in persistence we could use (whether its a full fledged DB or not i cannot say -- to me it seems like we're just storing an array of ints storing the IDs and then passing that to the API to get the actual metadata (title, desc)). i guess that's not the case?

one thing to keep in mind is that if the user deletes the app, they will lose the saved

i think thats fine for now

john-brunelle commented 6 years ago

Hmmm, curious can the API handle a list of ids and return the associated bounties? Might be easier to serialize the data to the device myself, although the Realm DB is fairly easy to set up.

owocki commented 6 years ago

@john-brunelle yes! use the ?standard_bounties_id__in=<list> GET param