gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.79k stars 772 forks source link

Add additional bounty owners #10459

Open GTChase opened 2 years ago

GTChase commented 2 years ago

User Story: As a funder I want to be able to add multiple bounty owners So that the payout isn't constrained to just myself

Acceptance Criteria

Form/field Initiation GIVEN i am creating a bounty WHEN I navigate to the payout step of the new wizard THEN there will be a field to add bounty owners AND this field should be a type ahead, searching on Gitcoin profile names AND by default I, original bounty creator should be added there by default AND i should be able to add multiple people as bounty owners outside of my self

Adding additional bounty owners GIVEN i am creating a bounty AND i am on the payout step of the new wizard WHEN i search for a profile in the Bounty Owner type ahead AND click the desired name THEN the dropdown should close and I should see that username next to mine in the bounty owner field AND anyone who is listed in that field should have access to pay any contributor out using their own wallet AND each name should have an 'x' to remove the as a bounty owner EXCEPT my self, the original bounty creator

Removing a name as a bounty owner, prior to submission GIVEN i am creating a bounty AND i am on the payout step of the new wizard WHEN i click the 'x' on someones name in the Bounty Owner field THEN that name should be removed from the list of bounty owners AND that profile should not have access to pay out bounty submissions

Product & Design Links: https://www.figma.com/file/8AFLrc4dx9xnMXUkWOAaAR/Existing-Bounties-Updates?node-id=33%3A1854

GTChase commented 2 years ago

The type ahead is acting very wonky.. For example.. i type in GTC, spinner spins.. Then i clear GTC out. When i open the Drop down it is only showing results for GTC.. Even after removing my search filter. I can show you tomorrow during stand up if you need.

Also, i dont see my self as selected as a bounty owner. we should either automatically have the user that is creating the bounty as a bounty owner.. Or filter out their name from being selected and make sure they can move on without having to select them.. WHich ever one is easier is fine by me.

cc. @nutrina

nutrina commented 2 years ago

@GTChase I suggest opening a new ticket for the typeahead issue. This is the same component that we use for "reserved for", so I am assuming that this topic applies to both fields.

Regarding the bounty owner: the creator of a bounty is implicitly linked as owner, the user does not need to add himself as owner. So was per our discussion we should leave this as it is.

GTChase commented 2 years ago

Fair enough, ill open a minor bug for that. Closing this story as is.

here is the bug mentioned above: https://github.com/gitcoinco/web/issues/10550