gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.79k stars 776 forks source link

Update how bounty amount displays #10470

Open GTChase opened 2 years ago

GTChase commented 2 years ago

User Story: As a contributor I want to see the value of the amount in USD when pegged to USD So that i get an accurate representation of the payout for any given bounty

Acceptance Criteria

Displaying bounty amount pegged in USD GIVEN i am on Gitcoin.co AND there is a bounty created pegged to USD WHEN i navigate to the bounty explorer OR view the details page of a bounty pegged to USD THEN all bounties that are pegged to USD should display as: [fixed amount of USD entered on bounty creation] USD in [payout token symbol selected on bounty creation] Example: 500 USD in ETH AND this same behavior should be reflected on the Bounty details page

Displaying bounty amount pegged to native token GIVEN i am on Gitcoin.co AND there is a bounty created pegged to USD WHEN i navigate to the bounty explorer OR view the details page of a bounty pegged to a native token THEN the bounty payout amount will display as ([Amount of native token entered] ETH) ([converted amount of token at that time] USD), the first value is fixed and second value is variable Example (2 ETH) (6,000 USD)

Product & Design Links: https://www.figma.com/file/8AFLrc4dx9xnMXUkWOAaAR/Existing-Bounties-Updates?node-id=123%3A622

Open Questions:

Notes/Assumptions:

GTChase commented 2 years ago

I cannot test this currently because i cannot load the bounty explorer at all.. Screen Shot 2022-04-26 at 5 13 45 PM

@nutrina

willsputra commented 2 years ago

http://gitcoin-review-10409-a81235f-1873182368.us-west-2.elb.amazonaws.com/issue/4

this shows up as "10.00 USD true" on the bounty explorer

image
nutrina commented 2 years ago

This has been fixed, needs to be deployed to review

nutrina commented 2 years ago

This has been deployed

willsputra commented 2 years ago

lgtm!

GTChase commented 2 years ago

Displaying bounty amount pegged to native token - this AC scenario needs a few minor tweaks..

cc. @nutrina moving back to todo to fix these two issues.

nutrina commented 2 years ago

@GTChase regarding your first point, this is due to the fact that the amounts are very small. This is the same behaviour in production at the moment:

image
nutrina commented 2 years ago

Regarding the 2nd point, we should discuss this in the standup

nutrina commented 2 years ago

Regarding the 2nd point, this looks good to me:

image
GTChase commented 2 years ago

This looks good now!