search

gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 771 forks source link

bug - avatar is wrong skin color #2150

Closed owocki closed 5 years ago

owocki commented 6 years ago

screenshot https://gitcoin.co/profile/owocki

Repro steps

  1. make an avatar. save it
  2. go to avatar builder
  3. wrong skin color is shown

expected behaviour:

  1. skin color is the same one as it is in my profile photo
thelostone-mc commented 6 years ago

@owocki is this still a problem ? was it some cache issue ?

Can't seem to recreate in on local. Also none of those avatar features ressemble you 🤦‍♂️

screen shot 2018-09-13 at 2 39 24 pm screen shot 2018-09-13 at 2 39 32 pm
owocki commented 6 years ago

yes its still a problem in production for me. can you repro in prod?

rabaut commented 6 years ago

I was able to reproduce this in production. See attached GIF bug-avatarskin

thelostone-mc commented 6 years ago

@SaptakS is checking it out ^_^

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to it.

Anish-Agnihotri commented 5 years ago

Is this a reproduce-able issue? Seems to be working for me in production and on the current master branch. If it is, I'd be glad to take a look at it, but I can't seem to invoke the problem on my end.

Edit

By chance, did you mean the actual color selector is not correct? Like this: Default_current

Since, the actual profile image updating seems to work in prod. Link to fullres gif.

evgeniuz commented 5 years ago

Was able to reproduce issue and found it's probable cause: it's because only background color is updated in localStorage where avatar builder takes colors from. Apart from skin tone issue also affects hair and clothing color. Will fix it shortly and submit PR.

evgeniuz commented 5 years ago

The issue was that parsing colour from avatar element path was splitting with '.' and that was breaking on production, as domain also contains dots (as opposed to localhost). Fixed this by taking split part from other end.

evgeniuz commented 5 years ago

@pmaojo, the issue is already fixed in https://github.com/gitcoinco/web/pull/2321.

pmaojo commented 5 years ago

thanks @evgeniuz I came from https://gitcoin.co/issue/gitcoinco/web/2150/1327, "created 18 hours ago"

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 6 months, 3 weeks from now. Please review their action plans below:

1) evgeniuz has started work.

Already fixed the issue, starting work for gitcoin to track this.

Learn more on the Gitcoin Issue Details page.

owocki commented 5 years ago

thanks for the fix @evgeniuz -- @pmaojo sorry for the bounty miscommuny.. i didnt realize that @evgeniuz was already on it.

owocki commented 5 years ago

@evgeniuz its working ... thanks! can you submit work so i can payout

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 50.0 DAI (50.0 USD @ $1.0/DAI) has been submitted by:

  1. @evgeniuz

@owocki please take a look at the submitted work:

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @evgeniuz.