search

gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 771 forks source link

Abandonment activities with empty price tags #2711

Closed octavioamu closed 5 years ago

octavioamu commented 6 years ago

Describe the bug

https://gitcoin.co/activity some of the activities are without price. We should omit price/denomination for these abandonment activities.

To Reproduce

https://gitcoin.co/activity

Expected behavior

Tags contain prices or don't show tags.

Screenshots

image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context **Smartphone (Add any other context about the problem here.)

kuhnchris commented 6 years ago

Awww, not filling out the template properly? :-(

https://github.com/gitcoinco/web/blob/3a9514f48ec3d6dbbe1d46a659dfd5f613be0680/app/retail/templates/shared/activity.html#L65

Here is the pain point to fix. basically the div tag token should be capsulated and not displayed when there is no data for it.

octavioamu commented 6 years ago

Not really, abandonment doesn't have value so is getting into the else 

{% else %}
    <span>{{row.metadata.value_in_token_old}}  - {{row.metadata.value_in_token}}  {{row.metadata.token_name}}</span>
{% endif %}

But also doesn't have any value so is just showing the -

kuhnchris commented 6 years ago

Still doesn't change the fact that "- " (because all the values are empty) and USD (below) will be displayed.

octavioamu commented 6 years ago

No it doesn't. There is two ways to go as I see 1- show the abandoned bounty value 2- don't show the tags if there is not value I believe the 2 is the best

Any other suggestion @kuhnchris ? I also was thinking about showing the positive fact of an abandonment (as a dev I have a bounty to check if I can do) instead of the negative "someone abandoned the task"

kuhnchris commented 6 years ago

I agree, we should not show the tags. We could show the "action" color-coded (like red for Abandonded, Green of completed, accepted, submitted, and gray for applied or funded) instead of the bounty value. Especially since the bounty value can change it doesn't make that much sense to put it in there anyways, IMHO.

image