search

gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 773 forks source link

as a user, i want to see history of a grant contributions on its public face, so i can know who's funded it #3286

Closed owocki closed 5 years ago

owocki commented 5 years ago

as a user, i want to see history of a grant contributions on its public face, so i can know who's funded it

https://gitcoin.co/grants/20/burner-wallet

there should be a way to view the contribution history of this grant. maybe we make 'updates' and 'milestones' as tabs, and add a third tab 'contributions'

acceptance criteria

new set of tabs on the grants page as follows

50522773-3c881400-0aff-11e9-8a87-218a022fdcda

on the contributions tab, it should have 3 types of element

  1. new subscription
  2. canceled subscription
  3. contribution made

each of which are loaded from the Subscription and Contribution objects in the DB

Timing

Pls only start work on this PR if you can submit a WIP PR in the next 3 days.

owocki commented 5 years ago

can we just reuse the existing https://gitcoin.co/grants/profile design and/or the activity feed design for this? i know @willsputra is out sick now too

willsputra commented 5 years ago

@owocki yeah I think we can reuse the existing design on Grants Profile

Nice to have: group by month and display the monthly total amount in USD/DAI so it's easy to see how much you've got each month.

grants detail

owocki commented 5 years ago

@willsputra looks good! cc @thelostone-mc @PixelantDesign

thelostone-mc commented 5 years ago

This does look cleaner 🙌 Have we wired up the activity on profile already ? @captnseagraves / @owocki

owocki commented 5 years ago

No it’s not wired up yet

On Sat, Dec 29, 2018 at 3:36 AM Aditya Anand M C notifications@github.com wrote:

This does look cleaner 🙌 Have we wired up the activity on profile already ? @captnseagraves https://github.com/captnseagraves / @owocki https://github.com/owocki

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gitcoinco/web/issues/3286#issuecomment-450483263, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfXifGl0A7Rxfzba0E95WebhHBAxLD3ks5u90XAgaJpZM4ZgBiD .

--

@owocki http://www.twitter.com/owocki

check out what i'm building on github http://github.com/owocki

or what i'm shooting on photoshelter http://photography.owocki.com/

or find me on twitter http://www.twitter.com/owocki, facebook http://www.facebook.com/kevinowocki, instagram http://instagram.com/owocki, linkedin http://www.linkedin.com/in/owocki, and owocki.com http://www.owocki.com/?utm_source=emailsig.

see you around teh internets!

PS -- Come to the next Boulder Blockchain https://www.meetup.com/Boulder-Blockchain/ meetup. Be there or be ^ 2. PPS -- Have I mentioned that *G*itcoin is live? More @ https://gitcoin.co

owocki commented 5 years ago

@willsputra can u share the skitch / design file for this

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.

owocki commented 5 years ago

All u

On Wed, Jan 2, 2019 at 6:56 PM Gitcoin.co Bot notifications@github.com wrote:

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 days, 17 hours from now. Please review their action plans below:

1) suhailvs https://gitcoin.co/profile/suhailvs has started work.

hi,

Have anyone started to working on this yet? If no one, I like to work on this issue. Hopes to make PR in 3 days.

Learn more on the Gitcoin Issue Details page https://gitcoin.co/issue/gitcoinco/web/3286/2063.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gitcoinco/web/issues/3286#issuecomment-451038971, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfXiVB0JSy7_dqVxQ2kodkewpOuvaCUks5u_WNUgaJpZM4ZgBiD .

--

@owocki http://www.twitter.com/owocki

check out what i'm building on github http://github.com/owocki

or what i'm shooting on photoshelter http://photography.owocki.com/

or find me on twitter http://www.twitter.com/owocki, facebook http://www.facebook.com/kevinowocki, instagram http://instagram.com/owocki, linkedin http://www.linkedin.com/in/owocki, and owocki.com http://www.owocki.com/?utm_source=emailsig.

see you around teh internets!

PS -- Come to the next Boulder Blockchain https://www.meetup.com/Boulder-Blockchain/ meetup. Be there or be ^ 2. PPS -- Have I mentioned that *G*itcoin is live? More @ https://gitcoin.co

suhailvs commented 5 years ago

@owocki on gitcoin it show work started. i didn't get you. can i start working on this issue?

suhailvs commented 5 years ago

@willsputra while adding the tab on grand detail page the click function on tabs doesn't seems working. are you using bootstrap tabs?

suhailvs commented 5 years ago

@willsputra while adding the tab on grand detail page the click function on tabs doesn't seems working. are you using bootstrap tabs?

adding these lines solves the problem:

<script src="{% static "v2/js/pages/tabs.js" %}"></script>
  <script>
    $(document).ready(function() {
      setupTabs('#grant-quickstart-tabs');
    });
  </script>
suhailvs commented 5 years ago

I finished creating the tabs(see commit). need to work on contributions tab. where I can found the design of contributions table view? Little busy now, i hopes to resume work after 11:30am gmt.

owocki commented 5 years ago

the tabs are here => https://github.com/gitcoinco/web/issues/3286#issuecomment-450395174

can you sumbit a WIP PR @suhailvs ?

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 months ago. Please review their action plans below:

1) usmanmuhd has started work.

Seems like a simple task, hopefully will get this done soon.

Learn more on the Gitcoin Issue Details page.

suhailvs commented 5 years ago

@usmanmuhd take a look at the PR 3385. that will be helpful

usmanmuhd commented 5 years ago

Thanks @suhailvs !

thelostone-mc commented 5 years ago

After syncing with @usmanmuhd.

The grant detail section. We'd have 2 tabs as opposed to 4 as we don't have screens for that yet. The tabs are

The Contributions tab would reuse the template from the profile and the three sections new subscription, cancelled subscription, contribution made

cc @captnseagraves we could reuse that bit of code even in grant profile

captnseagraves commented 5 years ago

@thelostone-mc @usmanmuhd

Can we make the tabs:

I think reusing the code from grants/profile makes sense.

owocki commented 5 years ago

sounds good to me. looking forward to seeing a PR!

@suhailvs thanks for your efforts thus far.. ill tip you out for the work you've done when we pay out @usmanmuhd too

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 80.0 DAI (80.0 USD @ $1.0/DAI) has been submitted by:

  1. @usmanmuhd

@owocki please take a look at the submitted work:

gitcoinbot commented 5 years ago
Pythonista ⚡️ A *Pythonista* Kudos has been sent to @usmanmuhd for this issue from @owocki. ⚡️ Nice work @usmanmuhd! Your Kudos has automatically been sent in the ETH address we have on file.
gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @usmanmuhd.