DESIGN - As a funder, I'd like to be know how to co manage **payment** of a bounty with my team members.

PixelantDesign commented 5 years ago

User Story

As a funder, I'd like to be know how to co manage payment of a bounty with my team members.

Why Is this Needed

Summary: Market validated customer need. Currently there is no ability to co manage the payout of bounties with team members at this time.

Description

New Feature: Shared Payment

This feature addresses only one of two parts to allow funders to share bounty permissions and share bounty payment.

Build the Mockup a how to use shared management and shared payment intro screen

Definition of Done

[ ] - Build the front-end experience of a how to use shared payment intro screen - this looks to be the org management screen

Data Requirements

[ ] data metrics tbd based on the experience created
[ ] funder retention could increase since this was a highly requested feature.

Additional Information

https://github.com/gitcoinco/web/issues/4843 https://github.com/gitcoinco/web/issues/4954

frankchen07 commented 5 years ago

@willsputra - did you say you had a design for this, and would add it to this ticket?

willsputra commented 5 years ago

@PixelantDesign @frankchen07 shared payout

frankchen07 commented 5 years ago

lookin' good - some quick feedback:

we can remove the side bar rockets, I think it's kind of distracting. Screen Shot 2019-09-09 at 14 46 44

this copy is okay for now, I'd add an indent for the bullets. Screen Shot 2019-09-09 at 14 47 03

does every admin / member have an info bubble? seems a little repetitive. I was thinking maybe the first two, but then it's inconsistent, or potentially incomplete, if everyone, for example, was an admin (then you won't get the info bubble as a "member") Screen Shot 2019-09-09 at 14 49 27

nit copy change "organization permissions" Screen Shot 2019-09-09 at 14 47 21

willsputra commented 5 years ago

@frankchen07 the rockets already exist in the current Manage Settings page. do we want to remove them?

(i kinda agree that removing the rockets would make the whole page cleaner!)

willsputra commented 5 years ago

updated design sharedpayout

frankchen07 commented 5 years ago

@willsputra agree with removing the rockets on the settings page too to clean it up

@frankchen07 and @danlipert to do a copy scrub here for the info popup buttons and the ipsum lorem page

danlipert commented 5 years ago

I've got some notes here based on the technical implementation:

First off, I wonder if we need to have the role information and popover shown at all? Its my understanding that the permissions are binary, in that people who have write access to your org/repo can control the bounties, and those who don't cannot. We have the role information in our database but I'd like to see more consideration of what is most effective for role-based permissions differences here.
Secondly, doing a separate sync for one user isn't really feasible since we have to sync each user on the platform at once to figure out what the permissions are. For example, if I sync my account, then I know what orgs/repos I have access to, but to know which of my teammates will share access to my bounties, I need to sync their accounts as well. We currently have a backend task for this that will run multiple times a day to refresh this information for each user on the platform.
Lastly, regarding whether or not this is an "opt-in" experience - we will be manually revoking each user's access token once this goes live, and then once they login again the new permission will be added to their Github access token and they'll see the 4th screen shown above. Whether or not this information is shown to each user can be behind a button, but we'll still be collecting the data, and its easier to just enable the new features for everyone across the board rather than feature flag it.

willsputra commented 5 years ago

@danlipert thanks for the feedback! :)

First off, I wonder if we need to have the role information and popover shown at all? Its my understanding that the permissions are binary, in that people who have write access to your org/repo can control the bounties, and those who don't cannot. We have the role information in our database but I'd like to see more consideration of what is most effective for role-based permissions differences here.

Gotcha, will explore more on how to display the info effectively.

Secondly, doing a separate sync for one user isn't really feasible since we have to sync each user on the platform at once to figure out what the permissions are. For example, if I sync my account, then I know what orgs/repos I have access to, but to know which of my teammates will share access to my bounties, I need to sync their accounts as well. We currently have a backend task for this that will run multiple times a day to refresh this information for each user on the platform.

Lastly, regarding whether or not this is an "opt-in" experience - we will be manually revoking each user's access token once this goes live, and then once they login again the new permission will be added to their Github access token and they'll see the 4th screen shown above. Whether or not this information is shown to each user can be behind a button, but we'll still be collecting the data, and its easier to just enable the new features for everyone across the board rather than feature flag it.

Just to clarify, so the permissions will be asked during the initial Gitcoin login right? Which means we don't need to ask them again on orgs onboarding?

willsputra commented 5 years ago

@danlipert if the permissions are binary, should we just show the people who have write access?

willsputra commented 5 years ago

@frankchen07 @danlipert updated based on today's discussion sharedpayout

octavioamu commented 5 years ago

@willsputra can you post the sketch file?

willsputra commented 5 years ago

@octavioamu sketch file: https://github.com/gitcoinco/creative/blob/master/Product/Shared%20Management/Shared%20Management%20-%20Milestone%20I%20and%20II.sketch

gitcoinco / web