search

gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 771 forks source link

MetaMask browser extension conflicts with Opera native CryptoWallet if enabled #5665

Closed aahutsal closed 3 years ago

aahutsal commented 4 years ago

Describe the bug If native Opera CryptoWallet is enabled on desktop Opera browser MetaMask chrome extension conflicts and user can't operate with MetaMask wallets.

To Reproduce

See this: image

Expected behavior Should not throw any Javascript exceptions regardless to CryptoWallet state (enabled or disabled)

image

Screenshots

Desktop

Mobile OS: Android Browser: Opera Touch Version: 2.1.3

MetaMask is not installed Screenshot_2019-12-23-17-15-59

kuhnchris commented 4 years ago

I see you have the Opera and Metamask combined in use - I also see Metamask complaining about that - sure that this is not connected somehow? Can you try to disable Metamask if you enable the Opera Internal CryptoWallet?

Thanks

sirlupinwatson commented 4 years ago

For me I still had this issue, i did not have the time to look why it was hapenning. Maybe i can have a look today after i am done with another one.

aahutsal commented 4 years ago

@kuhnchris Sorry for being not concrete enough. If I disable native wallet, it work smoothly with MetaMask. Haven't tried to work with native Opera Crypto wallet. I think code should be reviewed. I'll try to take that part myself if @owocki is ok with it.

The only thing I can confirm about Opera CryptoWallet - it does not work either on Opera Touch (mobile browser). Will update the issue now.

Screenshot_2019-12-23-17-15-59

molecula451 commented 4 years ago

This same thing it's happening with Brave Browser. If Native Brave Browser Crypto Wallet it's enabled and you have Metamask too, it will throw web3 conflict and in some cases if you Disable the native Crypto wallet and you try to use the MetaMask it will redirect to a page where it showing you have your crypto wallet disabled.

I Believe pretty much it's MetaMask having conflict when recognized other cryptowallets (native)

sirlupinwatson commented 4 years ago

@molecula451 HI, i just started to use Brave. Not sure about getting interference or not. I also use Metamask and Dapper, Arweave . Dapper always buggy the version i have anyway is still in beta but it did work still pretty good. Metamask, since a while there is many bug. It make me learn at least haha, learn to have other option

kuhnchris commented 4 years ago

Hello all,

thanks for clarifying the issue @agutsal . If you know where to lever the issue or could pin-point the issue I'm sure @owocki is fine with you opening a PR here. If you can give the engineering team a pointer or a hint where the issue may occour it will also help them finding the precise steps neccessary to reproduce it.

I assume there may be a conflict with the different providers trying to add their version or flavor of the web3 object into the website. Since this may cause confusion for the providers itself it may be a question of how to solve it in general. This actually makes me wonder:

Does this issue only occour on gitcoin, or does, for example radar-relay, cryptokitties or other crypto projects also have issues with those multi-provider-setups when you try to open them?

And, on related note, what's the reason you guys use the native browser wallet and MetaMask? Just for testing purposes or is that you 'productive' setup you use for you every-day work?

Thank you for all your help guys, Chris

sirlupinwatson commented 4 years ago

Hello all, thanks for clarifying the issue @agutsal . If you know where to lever the issue or could pin-point the issue I'm sure @owocki is fine with you opening a PR here. If you can give the engineering team a pointer or a hint where the issue may occour it will also help them finding the precise steps neccessary to reproduce it. I assume there may be a conflict with the different providers trying to add their version or flavor of the web3 object into the website. Since this may cause confusion for the providers itself it may be a question of how to solve it in general. This actually makes me wonder: Does this issue only occour on gitcoin, or does, for example radar-relay, cryptokitties or other crypto projects also have issues with those multi-provider-setups when you try to open them? And, on related note, what's the reason you guys use the native browser wallet and MetaMask? Just for testing purposes or is that you 'productive' setup you use for you every-day work? Thank you for all your help guys, Chris

On my side, i was using Metamask because it was the one who was mainly pointed at on web source. I use other walltets to try them and see. I am a pretty conservative guy, but if you try nothing you are not living any experience.

My experience with Metamask, was bad.

kuhnchris commented 4 years ago

@Sirlupinwatson1 yeah, no doubt there - everything has it's own pros and cons. The question is: why using 2 different wallets at once within the same browser

sirlupinwatson commented 4 years ago

@kuhnchris Good answer i guess. If you look it that way, we can then keep going on into this lol.

But only because right now there is many but many difference in the variations of cryptocurrency. Anybody can make his own and build up some stats and offer crypto to all of us. And they are not offering any alternative to work with either their web site or the way to get the crypto.

Metamask is just not made right now for beginner or Mister and Mme anyone, but for Novice player. This is my opinion after using it for a while.

Now there is something going on with all the new wallet available and new browser, giving away crypto and the option to let you mine online with a apparently boost…. this make me still perplex about it but really

octavioamu commented 4 years ago

I been using opera a lot on my test with gitcoin and is working fine. Of course any web3 browser + wallet enabled + metamask will fail as creating a big conflict.

From the console print on the ticket: image