search

gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 771 forks source link

Allow gitcoin.co/tips to support Sablier style streams #5914

Closed PaulRBerg closed 3 years ago

PaulRBerg commented 4 years ago

Prize Bounty

DAI 500.

Challenge Description

Please add a toggle to existing gitcoin.co/tip flow to allow user to toggle between legacy tips and stream tips.

To complete this bounty, you will need to read the Sablier protocol's documentation. If you want to understand more about money streaming, here's a couple resources for you:

Submission Requirements

  1. Has to work on mobile
  2. Has to work on gitcoin.co, pay.sablier.finance and app.sablier.finance as well, therefore you have to create the stream through the Payroll.sol proxy, not the core Sablier.sol (please reach out, I know this can be a bit confusing)
  3. If no address is on file for a profile, then no stream can be done, but the user can send an invite email to that user asking them what their eth address is
  4. (Optional, but ideal) the user should not have to sign two transaction, think about using DAI's permit functionality or hack smth with CREATE2

Submission Deadline

Feb 12, 2020.

Judging Criteria

Best submission that meets all or almost all requirements from above.

Winner Announcement Date

We aim to review submissions within one week after the hackathon ends, therefore expect a result until Feb 19 at worst.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 500.0 DAI (500.0 USD @ $1.0/DAI) attached to it as part of the sablierhq fund.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 week, 3 days ago. Please review their action plans below:

1) man-jain has started work.

Will work on integrating Gitcoin with Sablier as per requirements 2) santteegt has started work.

Will allow streaming tips through the Gitcoin tips UI using Sablier Salary proxy contract

Learn more on the Gitcoin Issue Details page.

walidmujahid commented 4 years ago

For those working on this for the hackathon -or not-, here is the rinkeby proxy: https://rinkeby.etherscan.io/address/0x7ee114c3628ca90119fc699f03665bf9db8f5faf

PaulRBerg commented 4 years ago

hey @walidmujahid thanks for sharing that. FWIW, this information is also available in our GitHub repository:

Capture d’écran 2020-02-03 à 23 08 58
gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 500.0 DAI (500.0 USD @ $1.0/DAI) has been submitted by:

  1. @santteegt
  2. @man-jain

@PaulRBerg please take a look at the submitted work:

PaulRBerg commented 4 years ago

I know I have been slacking off on reviewing this, but I really couldn't find the time - I briefly managed to pull a copy of the Gitcoin codebase the other day, but I stumbled upon a bug.

@Man-Jain, @santteegt, can you both please send me a screen recording of your work? Either on Discord, Telegram or email.

Man-Jain commented 4 years ago

@PaulRBerg Sent you a Video with the demo on Discord.

PaulRBerg commented 4 years ago

I tried to build the Gitcoin codebase again but unfortunately it didn't work. I reported the errors I got on Slack.

@Man-Jain, @santteegt, can you please stream me 0.1 DAI to my Gitcoin account? I want to see how the notification email looks like and whether I can properly withdraw from Sablier. On mainnet.

Thanks!

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 500.0 DAI (500.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

gitcoinbot commented 4 years ago

⚡️ A tip worth 400.00000 DAI (400.0 USD @ $1.0/DAI) has been granted to @santteegt for this issue from @PaulRBerg. ⚡️

Nice work @santteegt! Your tip has automatically been deposited in the ETH address we have on file.

gitcoinbot commented 4 years ago

⚡️ A tip worth 100.00000 DAI (100.0 USD @ $1.0/DAI) has been granted to @man-jain for this issue from @PaulRBerg. ⚡️

Nice work @man-jain! Your tip has automatically been deposited in the ETH address we have on file.

PaulRBerg commented 4 years ago

Okay so after reviewing the videos, analysing the code contribution and confirming that the streams you created work on app.sablier.finance, I decided to split the bounty in two:

I have to admit this was very, very hard to judge because both submissions were good. I ultimately decided to choose @santteegt as the winner since he managed to implemented the email functionality (the stream link was in the email). Thanks for participating!

@owocki Santiago's PR is good to be merged: https://github.com/gitcoinco/web/pull/5976

I guess we'd need to run some tests with the production SendGrid API keys before announcing this.

owocki commented 4 years ago

thanks; catching up after parental leave this week. planning on paying out this week

On Sun, Feb 23, 2020 at 6:35 AM Paul Razvan Berg notifications@github.com wrote:

Okay so after reviewing the videos, analysing the code contribution and confirming that the streams you created work on app.sablier.finance, I decided to split the bounty in two:

I have to admit this was very, very hard to judge because both submissions were good. I ultimately decided to choose @santteegt https://github.com/santteegt as the winner since he managed to implemented the email functionality (the stream link was in the email). Thanks for participating!

@owocki https://github.com/owocki Santiago's PR is good to be merged:

5976 https://github.com/gitcoinco/web/pull/5976

I guess we'd need to run some tests with the production SendGrid API keys before announcing this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gitcoinco/web/issues/5914?email_source=notifications&email_token=AAD5PCNBUMI2O5D3M62XPCDREJ3QXA5CNFSM4KOIS6Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMV357A#issuecomment-590069500, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5PCKKGW4I2ISDOAYHK6TREJ3QXANCNFSM4KOIS6QQ .

--

@owocki http://www.twitter.com/owocki

gitcoin is live and has generated over $3.5mm for Open Source Software - see our results https://gitcoin.co/results

PaulRBerg commented 4 years ago

@owocki hope you enjoyed your family time! I've already paid out this bounty. The only thing left is to merge it into Gitcoin and announce it publicly.

owocki commented 4 years ago

ok ; which one did u want to merge? https://github.com/gitcoinco/web/pull/5976

can u comment there?

and can we close the other PR?

PaulRBerg commented 4 years ago

I commented there. @Man-Jain sorry to tag you, any chance we could close #5982? Thank you!