search

gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 771 forks source link

As a funder/contributor I'd like to know who I'm following and who is following me on the Gitcoin platform. #6095

Closed PixelantDesign closed 4 years ago

PixelantDesign commented 4 years ago

User Story

As a funder/contributor I'd like to know who I'm following and who is following me on the Gitcoin platform.

Why Is this Needed

On profile, a follower count is displayed but does not say who. It also doesn't show me who I'm following. This is a front end and backend ticket.

Description

Type: Feature

Current Behavior

Follower count is displayed but does not say who

Expected Behavior

Show who I'm following, show who is following me

Definition of Done

Add following/followers section

Screen Shot 2020-02-28 at 6 15 59 AM

Show who I'm following

Screen Shot 2020-02-28 at 6 15 21 AM

Show ability to unfollow on hover

Screen Shot 2020-02-28 at 6 15 35 AM

On follower tab - show who is following me show a button so that a user can follow back

Screen Shot 2020-02-28 at 6 15 41 AM

Additional Information

Screen Shot 2020-02-28 at 6 32 58 AM Screen Shot 2020-02-28 at 6 32 45 AM
gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 1.4 ETH (315.24 USD @ $225.17/ETH) attached to it.

zoek1 commented 4 years ago

In case the assigned user couldn't start this task, I'll happy to work on this. I think I could finish this weekend

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 month ago. Please review their action plans below:

1) jschiarizzi has started work.

Start with new tab on profile break into two toggle-able sides for followers and following people. generate list of each group via follower storage. implement buttons as designed

Learn more on the Gitcoin Issue Details page.

danlipert commented 4 years ago

@jschiarizzi @PixelantDesign for this to have good performance we'll want to make sure to have pagination via a show more button at the bottom of the list, or infinite scroll. Also, would be nice to have a search bar that filters the results as you type so that you can look up a specific user

cupOJoseph commented 4 years ago

thanks for the input, @danlipert. search is probably not in this scope, but I was thinking infinite scroll after 50 users at time? not many people have much more than that for followers at the moment.

PixelantDesign commented 4 years ago

Sounds good @jschiarizzi! Looking forward to seeing a PR!

cupOJoseph commented 4 years ago

Monday update: went to west virginia to drink moonshine instead of work on this over the weekend. Will have a better update by tomorrow night.

cupOJoseph commented 4 years ago

update: took me longer than I care to admit to get oauth running locally this evening. A challenge is testing followers locally since no one else follows my local profile on my local machine haha

update adds new FOLLOW tab It steals all the structure of the ACTIVITY feed, but we can just loop through followers instead of recent activity for the list. I didnt realize before, but the activity feed uses infinite scroll, I see no reason to change how thats already implemented.

tomorrow:

danlipert commented 4 years ago

@jschiarizzi you should test by setting up multiple users in your local. I know Github limits users to one account so either create superusers through the django createsuperuser command or create one superuser first (you'll want to do this anyway to access the django admin) and then create them manually in the admin

cupOJoseph commented 4 years ago

thanks for the tip @danlipert, thats very helpful

cupOJoseph commented 4 years ago

Still here. Will have a bigger update tonight.

PixelantDesign commented 4 years ago

Looking forward to it @jschiarizzi !

cupOJoseph commented 4 years ago

I made some more commits. the last thing I'm missing from the design is the different color [Following] and [Unfollow] and [Follow] buttons.

Still struggling to test this with users, i dont understand how the users i've created in django can interact. I followed the docs to make a superuser and then added some new test users and data. but when i look for their profile in localhost:8080/profile/myTestUser I just get 404s.

Screen Shot 2020-03-10 at 9 30 33 PM Screen Shot 2020-03-10 at 9 27 43 PM
cupOJoseph commented 4 years ago

The world was been a little crazy the last few days. I'm still here. Planning to spend some more time figuring out the django setup tomorrow.

PixelantDesign commented 4 years ago

Thanks for the update @jschiarizzi

cupOJoseph commented 4 years ago

Sometimes getting weird errors trying to load everything after making changes in django. I'm not touching townhall so why is this breaking things

Screen Shot 2020-03-19 at 7 53 22 PM
owocki commented 4 years ago

what branch are you based off of? i dont see that code in master

On Thu, Mar 19, 2020 at 5:58 PM Joseph Schiarizzi notifications@github.com wrote:

Sometimes getting weird errors trying to load everything after making changes in django. I'm not touching townhall so why is this breaking things [image: Screen Shot 2020-03-19 at 7 53 22 PM] https://user-images.githubusercontent.com/9449596/77125350-ed881080-6a1b-11ea-8efc-e234f28d1e81.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gitcoinco/web/issues/6095#issuecomment-601469582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5PCOSNY5ZCKIGD3X5YKDRIKWRLANCNFSM4K5OKJFQ .

--

@owocki http://www.twitter.com/owocki

gitcoin is live and has generated over $3.5mm for Open Source Software - see our results https://gitcoin.co/results

cupOJoseph commented 4 years ago

I cloned master for https://github.com/jschiarizzi/web

owocki commented 4 years ago

hmm can you pull the latest? i dont see that code in master anymore https://github.com/gitcoinco/web/blob/master/app/townsquare/views.py#L230-L236

On Fri, Mar 20, 2020 at 1:25 PM Joseph Schiarizzi notifications@github.com wrote:

I cloned master for https://github.com/jschiarizzi/web

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gitcoinco/web/issues/6095#issuecomment-601873261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5PCOGZWI4TOHXGV3C5MLRIO7IXANCNFSM4K5OKJFQ .

--

@owocki http://www.twitter.com/owocki

gitcoin is live and has generated over $3.5mm for Open Source Software - see our results https://gitcoin.co/results

cupOJoseph commented 4 years ago

Okay so this doesnt work yet, @zoek1 would you help me finish it?

Some good helpful things:

Some work still on

PixelantDesign commented 4 years ago

Thanks for the update @jschiarizzi! @zoek1 are you able to help get this to the finish line?

cupOJoseph commented 4 years ago

DM-ing on gitcoin chat with @zoek1 now

cupOJoseph commented 4 years ago

Saturday update, zoek1 and I worked on this for a bit today.

current progress is:

Screen Shot 2020-03-28 at 11 26 42 PM

Just missing a few small beautification things, and the send message button. all the functionality is done. Needs maybe another hour I hope, tomorrow.

cupOJoseph commented 4 years ago

As per Alisa's guidance, just blue follow buttons when you dont follow the user.

Screen Shot 2020-04-02 at 4 11 45 PM
cupOJoseph commented 4 years ago

6301

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 1.4 ETH (230.87 USD @ $164.91/ETH) has been submitted by:

  1. @jschiarizzi

@PixelantDesign please take a look at the submitted work:

gitcoinbot commented 4 years ago
Pythonista ⚡️ A *Pythonista* Kudos has been sent to @jschiarizzi for this issue from @PixelantDesign. ⚡️ The sender had the following public comments: > Thanks for your help! Nice work @jschiarizzi! Your Kudos has automatically been sent in the ETH address we have on file.
gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 1.4 ETH (298.1 USD @ $212.93/ETH) attached to this issue has been approved & issued to @jschiarizzi.

gitcoinbot commented 4 years ago

⚡️ A tip worth 200.00000 DAI (200.0 USD @ $1.0/DAI) has been granted to @zoek1 for this issue from @jschiarizzi. ⚡️

Nice work @zoek1! Your tip has automatically been deposited in the ETH address we have on file.