gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 771 forks source link

Confirm before emailing all contributors in Gitcoin grants campaigns #6415

Open auryn-macmillan opened 4 years ago

auryn-macmillan commented 4 years ago

User Story

comment: As someone running a Gitcoin Grant campaign, I want a confirmation step when I submit a post that will be emailed to all of my contributors, so I don't spam them with incomplete/improperly formatted emails if I accidentally hit [ENTER] while typing an update.

Why Is this Needed

comment: # Currently, it is really easy to accidentally post a message if you try to create a new line. [shift] + [enter] gives makes a new line, while [enter] posts the message.

This behaviour is fine when posting to the feed, because you can simply edit or delete the post if it is incorrect.

However, when you have selected the checkbox to email the message out to all of your contributors, mistakenly hitting the [enter] key sends the incomplete message out as an email, which cannot be undone.

A confirmation step, or removing the post on [enter] function while the checkbox is TRUE, would mostly alleviate this issue.

Summary:

Description

Type: Bug

Current Behavior

comment: No confirmation step when email checkbox is TRUE

Expected Behavior

comment: # Confirmation step or no send on [enter]

owocki commented 4 years ago

this is a good idea

On Fri, Apr 10, 2020 at 7:24 AM Auryn Macmillan notifications@github.com wrote:

User Story

comment <#m-2007965064899567938>: As someone running a Gitcoin Grant campaign, I want a confirmation step when I submit a post that will be emailed to all of my contributors, so I don't spam them with incomplete/improperly formatted emails if I accidentally hit [ENTER] while typing an update. Why Is this Needed

comment <#m-2007965064899567938>: # Currently, it is really easy to accidentally post a message if you try to create a new line. [shift] + [enter] gives makes a new line, while [enter] posts the message.

This behaviour is fine when posting to the feed, because you can simply edit or delete the post if it is incorrect.

However, when you have selected the checkbox to email the message out to all of your contributors, mistakenly hitting the [enter] key sends the incomplete message out as an email, which cannot be undone.

A confirmation step, or removing the post on [enter] function while the checkbox is TRUE, would mostly alleviate this issue.

Summary: Description

Type: Bug Current Behavior

comment <#m-2007965064899567938>: No confirmation step when email checkbox is TRUE Expected Behavior

comment <#m-2007965064899567938>: # Confirmation step or no send on [enter]

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gitcoinco/web/issues/6415, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5PCKZ46MJCUHIFGJRV7LRL4MY7ANCNFSM4MFOLWAA .

--

@owocki http://www.twitter.com/owocki


gitcoin is live and has generated over $4.0mm for Open Source Software - see our results https://gitcoin.co/results