search

gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 771 forks source link

Bug: can't Stark work because of fbq is not defined facebook tracking #6625

Open x5engine opened 4 years ago

x5engine commented 4 years ago

Bug: this is not defined somehow fbq('trackCustom', 'Start Work'); 

var add_interest = function(bounty_pk, data) {
  if (document.interested) {
    return;
  }
  fbq('trackCustom', 'Start Work');
  return mutate_interest(bounty_pk, 'new', data);
};

Additional context image

So currently not one can submit work but if I run that function without the track missing function it works!

x5engine commented 4 years ago

this is urgent and affect all bounties @octavioamu @owocki

x5engine commented 4 years ago

I guess this is why!

https://github.com/gitcoinco/web/blob/686c56e38f59535a33833559b35d45c3c9ef94b7/app/retail/templates/shared/fbpixel.html#L32

facebook tracking is not working here at all!

danlipert commented 4 years ago

@x5engine thanks for reporting this! Seems some people are able to start work but it does seem like something is wrong. @octavioamu I checked the bounty detail page, as well as some other pages and didn't see the injected facebook pixel code in the source code. Do you know why GTM is not injecting it?

x5engine commented 4 years ago

yeah why do you even track people with facebook? @danlipert

octavioamu commented 4 years ago

@x5engine do you use some ads blocker? Also what browser are you using? Can you give us more data?

x5engine commented 4 years ago

@octavioamu yes I always use Adblock and I actually have 3 extension against ads and tracking!

I really don't want any corporation tracking my page views or action essentially on a blockchain project! This should be an opt in or out option in privacy! And also the IP gathering of each client!

octavioamu commented 4 years ago

@x5engine I just deployed a fix for this. Can you try again and tell me if is fine now?

x5engine commented 4 years ago

works perfectly now!

But why facebook tracking???

octavioamu commented 4 years ago

works perfectly now!

But why facebook tracking???

We are trying facebook ads to bring more hackers into hackathons. Then we need facebook pixel so we can understand if work for us and the community or not.

x5engine commented 4 years ago

ah okay, I understand but there is many other advertise blockchain platforms which keep anonymity too? fb is well known for not being good with privacy!

also why gather IPs?

owocki commented 4 years ago

I’d be open to adding a setting called “do not track” so that people can then this stuff off. Maybe open up a seperate ticket and we can discuss there?

On Mon, May 11, 2020 at 10:42 PM X5 Engine notifications@github.com wrote:

ah okay, I understand but there is many other advertise blockchain platforms which keep anonymity too? fb is well known for not being good with privacy!

also why gather IPs?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gitcoinco/web/issues/6625#issuecomment-627104185, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5PCPUISR4N56GU3QSGBLRRDHT5ANCNFSM4M43XX5Q .

--

@owocki http://www.twitter.com/owocki

gitcoin is live and has generated over $4.6mm for Open Source Software - see our results https://gitcoin.co/results

x5engine commented 4 years ago

sure, that's very essential to let people know at least about it then be able to disable it

here it is https://github.com/gitcoinco/web/issues/6636

thanks