round 8 bug / improve list

[thelostone-mc]

MAJOR

• [x] checkIsCurator function is broken as the logic doesn't fit the data (map collections array and check curators on each one).
• [x] removeCollection doesn't work not id is found.
• [x] fix to 2 decimals in prediction curve UI FIX: 913db656f
• [x] make background image in RoutingPolicy as optional FIX: fc9b24a9c
• [x] add new field name in RoutingPolicy to make it easier to identify FIX: fc0c8bd54
• [x] in UI customer-name is not appended to URL image FIX: 76ff4383d
• [x] CLR banner not being updating in UI despite setting image in GrantCLR.logo FIX: 97370ea7f
• [x] Appending / URL to endpoint should not return 404 FIX: 5e56dff43
• [x] If grant is part of multiple rounds -> the round names are not appended
• [x] made CLR banners into accordion so that it is collapsible and store that boolean in local-storage
• [x] edit grant broken. FIX: 7547b5fbf

MINOR

• [x] ensure error are cleared after submitting a match pledge FIX: c7767fc63
• [x] fix broken collections UI FIX: 821de8c9c
• [ ] fix alignment in prediction curve UI image
• [x] Show My Items on landing only if user is logged in FIX: 1b33dcdfe
• [x] update text in Did you know section FIX: fe0b6f11c
• [x] Show Add to collection in card only if user is logged in and has a collection of their own image
• [x] Sidebar should auto-close after canceling grant
• [x] Remove Current & Past Sponsors in UI FIX: 42c4d73ab
• [x] Hide prediction curve when a grant is not part of a CLR FIX: ad530e813
• [x] related grants styles

[owocki]

just tested, feels pretty rough. here are my QA notes (all in latest chrome + metamask):

showstoppers

• [x] i cant actually test the 'new matching partner' stuff bc no collections or categories show up ( https://bits.owocki.com/2Nu0xE25 & https://bits.owocki.com/RBu974Pp ) aditya: this works as discussed offline

• [x] when i try to edit a grant i get this error https://bits.owocki.com/jkuYqY4y error in console is error: grant creation failed with status: 400 and message: error: zcash_payout_address must be a transparent address

• [x] CANCEL GRANT does not seem to work. when i type in CONFIRM in the alert bar, nothing happens. nothing to let me know if my grant was actually canceled or not. aditya: the grant cancellation works, the sidebar should auto close (has been captured above)

• [x] cannot create a grant. it just says 'verify form errors' when there are no actual form errors https://bits.owocki.com/DOuogor5 - i think this happened when i had a validation issue but then fixed it. i could never get past validation again without refreshing page. aditya: tested this offline with same steps. it works. make sure you have latest + cache is cleared + do a hard reload octavio: looking the gif the problem was because the second handle without @, and there was no error report for that field.

• [x] on zksync checkout, i was taking to a new page checkout.zksync.com which had the following issues

  1. on my grants page, i see this error after going to zksync https://bits.owocki.com/z8u454jZ - looks related to this https://bits.owocki.com/YEuQKQxX
  2. i am never taken to the 'success, you checked out, tweet about it now!' modal after checkout

• [x] on standard checkout, i sign this message ( https://bits.owocki.com/qGulylkk ) and then nothing happens. maybe related to this JSON error again? https://bits.owocki.com/4guOzO6E

major

• [x] 'add to cart' should not be the default action for the collections list view https://bits.owocki.com/xQuYZnK9 , it should be 'view collection'

• [x] banner is not updated up top (even if i upload one in the admin i get this https://bits.owocki.com/2Nu0x05X)

• [ ] http://localhost:8000/_administrationgrants/grantclr/add takes forever to load - probably needs a raw_id field on the owner field

• [x] related grants is empty when first clicked ( https://bits.owocki.com/xQuYZY4x ) - then takes about 15 seconds to load when it finally does aditya: @octavioamu made it as an on demand CALL which aka makes the call only then click the tab as opposed to slowing down the page by loading all the data at one go

• [x] What's the deal with the grants clr banner here? https://bits.owocki.com/6quxkxeD its completely white aditya: pull the latest code. it was fixed up. if you want to set an image there set it via GrantCLR table

• [x] can we remove 'add all to cart' from the collection view page pls? https://bits.owocki.com/xQuYZYYA

• [x] on grant creation, why are we forcing people to add an @ symbol? seems like needless user work, we can just add it on the backend if needed. don't introduce unnecessary friction pls https://bits.owocki.com/qGulylqy

• [x] total on my cart is wrong. 4x1 DAI = 4 DAI, not 1 DAI https://bits.owocki.com/12uK5KbX

attention to detail stuff

• [x] I don't see the 'show idle grants' filter on the left-hand side of the nav anymore. are we not filtering out idle grants anymore? if so, why not? that wasn't a requirement.

• [x] 'become a matching partner' is lopsided https://bits.owocki.com/2Nu0xjZy aditya: pull in the latest code, you should you create a grant button as well https://user-images.githubusercontent.com/5358146/100470286-f5956580-30fd-11eb-8d83-27468a7ca9e0.png

• [ ] the page refreshes as I click around the nav; I thought we were fixing that this round? aditya: that is being worked on by @aamustapha. It might get in a little late

• [x] if I remove my grant from cart on the side cart the 'remove from cart' button does not change on the UI https://bits.owocki.com/qGulyvWn octavio: I added the "remove from cart" on the vue components if the component is added but the sidebar cart is not build on vue so is not reactive, this will be solved when we migrate the sidebar to vuejs, but at least for now people can see the grants they added when scrolling.
  octavio: done.

• [x] it'd be nice if i could click/unclick this label to check/uncheck the box https://bits.owocki.com/mXu5j5Wl

• [x] the 'back to grants' breadcrumb that used to be consistent across each grant page + cart is no longer on the grant detail page https://bits.owocki.com/p9urlrvN octavio: was added today please pull changes.

• [x] i setup an 'infra tech' round and made it active and ran 'create_page_cache', but it never showed up on the left navbar as a round https://bits.owocki.com/6quxkQmO aditya: tested this out and works. make sure Grant CLR is active and end date is in the future

• [x] follow button on grant detail page does nothing if youre logged out (we should tell the user they should login first)

could not test

• [x] a grant being in multiple CLR rounds at once aditya: tested this

• [x] emails - never got any aditya: got emails for grant creation + contribution + cancellation

• [x] self-service matching partner stuff; i was blocked by the showerstopped issue above. aditya: this was due to a grant with a weird title in live -> fixing that up should fix it. This works in live and I've tested this as well

• [x] i could not test many of the trustbonus items, due to lack of setup on some of them, and lack of actually having those services on others. will need to make sure it's well tested elsewhere.

• [x] videos - where do i add a video to my grant? i wasn't compelled to in any place? Octavio: on grant edition you have a button to add videos urls on the description

• [x] does the 'last update' field actually update when the grant is edited, @octavioamu ? that'll be important Octavio: yes you can check next to the title, I will update without reload the page.

[octavioamu]

on grant creation, why are we forcing people to add an @ symbol? seems like needless user work, we can just add it on the backend if needed. don't introduce unnecessary friction pls

I added better validation for this but extract the username of any format seems overkill to me. I was looking on some of the possible patterns https://regex101.com/r/s6JoZ5/3

[owocki]

testing latest build

• [x] cannot add to cart on the grants/clr page ( http://localhost:8000/grants/clr/ethereum/7/MATIC/? )

• [x] i pulled the latest origin/grants-round-8 and i still can’t checkout on it.. this is what i get https://bits.owocki.com/qGulyqe9

• [x] why do twiter handles require @ signs all of a sudden? feels like something we can enforce on the backend, instead of adding validation thats cumbersome to the user.

[thelostone-mc]

@chibie could you take a look at the twitter handle ! let's make it such that it auto adds an @ if it's not present when frontend sends it to the backend ?

@owocki looks like there edit grants had to be fixed up a bit cause it was setting ETH payout address to undefined on edit. 7547b5f fixes it So when you do pull it in and test -> do ensure the ETH address for the grant is set in admin

[zoek1]

@owocki I managed the twitter handle in the PR #7962

[zoek1]

Also I'm still getting the error: zcash_payout_address must be a transparent address when i try to edit any grant, the fix isn't merged yet?

[thelostone-mc]

@zoek1 could you make sure your grant has

• zcash_payout_address has value '0x0'
• admin_address has a valid ETH address ?

and you have the latest changes

[owocki]

I added better validation for this but extract the username of any format seems overkill to me.

i just dont want the grant creation form to fail validation bc of the lack of an @ symbol. seems this could be accomplished by just doing an alphanumeric regex. if we want to ensure consistence on the backend, the @ symbol can be added on hte backend.

more testing notes:

• [x] after i add a grant to cart on grant detila page, the side cart no longer shows. where do i go to checkout?

• [x] i can't seem to test a grant being in multiple CLRs bc i can't make a contribution + get it to store in the DB... it'd be good to know someone has tested this aditya: i've tested this

• Grant 1018: UI

• Grant 1018 in CLR table

• Grant 1018 effective CLR (5956 + 864)

• [x] when i create a grant contribution on the frontend, i dont see anything in the DB (i wanted to test to make sure that when i check 'include this in CLR' it actually stores that state in the DB) aditya: I have a feeling your local setup isn't right or something is wonky. Tesing this for a 3rd time with the latest code !

[octavioamu]

after i add a grant to cart on grant detila page, the side cart no longer shows. where do i go to checkout?

I just pushed a commit adding the sidecart back

[apbendi]

Twitter verification on the Trust Bonus tab is broken in the grants branch, as far as I can tell. Seems like the regression came from this PR, which I commented on with a bit more context: https://github.com/gitcoinco/web/pull/7962

@zoek1, can you expand on why you were modifying the twitter verification endpoint? That endpoint is used for the Trust Bonus. Was it your intention to change the behavior of the Trust Bonus?

[apbendi]

Attempting to test SMS verification from the Trust Bonus tab gives the following error from the backend:

, uri, response, 'Unable to fetch record')
web_1            | twilio.base.exceptions.TwilioRestException:
web_1            | HTTP Error Your request was:
web_1            |
web_1            | GET /PhoneNumbers/REDACTED
web_1            |
web_1            | Twilio returned the following information:
web_1            |
web_1            | Unable to fetch record: Authenticate
web_1            |
web_1            | More information may be available here:
web_1            |
web_1            | https://www.twilio.com/docs/errors/20003

Has our API key or auth token changed? (Reminder not to post these here)

[apbendi]

Need a bit more direction on how to regression test Google Verification: https://github.com/gitcoinco/web/pull/7631#issuecomment-736207735

Should still be working but would like to test locally

[zoek1]

@apbendi my intention wasn't to modify the trust bonus, just the twitter grant verification. The error is due to wrong conditional statement. The fix for that is here https://github.com/gitcoinco/web/pull/7974

[danlipert]

• [x] Editing an ETH grant now throws an error when trying to save. The error displays in the UI and in the console the error is: _detail-component.js:99 error: grant edit failed with status: 400 and message: error: zcash_payout_address must be a transparent address Seems that for ETH grants we are trying to validate their zcash address which doesn't apply here.

edit: fixed via https://github.com/gitcoinco/web/pull/7977

[danlipert]

• [x] When creating a grant, the validation fails if the twitter username does not start with an "@" symbol. While I appreciate the attention to detail to validate the twitter handle starting with @, its bad UX as the placeholder text shows a username without the @ symbol.

edit: fixed via https://github.com/gitcoinco/web/pull/7976 allows starting @ symbol or not in frontend while it is stripped in backend per @owocki 's comment above

[danlipert]

While checking out with multiple ETH grants in my cart via zksync, I received an error alert in the UI while I was redirected to the zksync checkout. Zksync checkout worked perfectly as expected, and when finished I was returned to the grants page and received the success modal, but during this time if I return to the cart page the alert is shown which reads "Insufficient balance to complete checkout". I don't know if this refers to the zksync balance being insufficient as I a) did have enough funds in my wallet to complete checkout and b) did not have any L2 funds at this time, but either way if that is "expected behavior" its definitely confusing/scary for users and the copy and alert style need to be changed.

[thelostone-mc]

^ @mds1

[mds1]

Hey @danlipert. The insufficient balance modal should only show if you have insufficient funds in both L1 and L2. Can you clarify the steps to reproduce? I'm not sure I follow.

but during this time if I return to the cart page the alert is shown which reads "Insufficient balance to complete checkout"

This is the main part I'm confused on. The success modal redirects you off the cart page, so did you then go back the cart, and the cart was not cleared? Or did you add new grants to your cart after? Or something else?

Also, what was in your cart at the time of that second checkout? It looks like you may have had an empty "amount" field based on the console error messages showing vaule=""

[danlipert]

@mds1 I had sufficient funds in L1 but not L2. Not sure exactly how to reproduce. What happened was the zksync flow opened in a new tab, and i went back to the cart tab just to check and the error was there while I was going through the zksync flow. Once I finished the zksync flow I was redirected back to the success modal screen. I took the screenshot while I was going through the zksync flow. I'm pretty sure all the amount fields had something in them as I got the appropriate number of txns in the zksync checkout explorer link list, but they were all very small amounts.

[mds1]

@danlipert Ahhh I see, got it, thanks for the additional info! I'll look into this today

[willsputra]

Browser: Brave Mac 1.17.73

Major

• [x] zkSync Checkout: Tried contributing 0.5 DAI to two grants with optional tip, got a "Transactions batch summary fee is too low" error tx | error @mds1 will: didn't seem to get this error again. looks like this is fixed.
• [x] Grant Contribution Success Email: I contributed 0.5 DAI but email shows 1.0000 SAI contrib | email

Minor

• [x] Quick View: Wall of Love numbers scroll down as you scroll down. screenshot
• [x] Grant Detail: Description font is different screenshot
• [x] zkSync Checkout: Are "Grants Round 8+ Dev Fund" and "Grants Round 7+ Development Fund" different? Current optional tip goes to "Grants Round 7+ Development Fund" screenshot
• [x] Edit Grant: Including @ on the twitter handle field results in @@ edit | displayed

[danlipert]

Thanks @willsputra ! I also just got the SAI / DAI issue but only for one of the grants (gitcoin dev fund optional contribution) so probably has something to do with when the grant was created back when you could specify a specific type of token you accepted. I also received 4 emails for the 4 rolled up zksync contributions :/ But was able to successfully check out. @willsputra the error you got I believe has to do with the calculation of the zksync fee being larger than what you would have saved by using it or something like that.

• [x] batch email not working, receiving separate emails per contrib EDIT: this PR was rolled back before deploy due to bugs aditya: Doubtful ! Given that subscription creation happens in celery. I'm not sure how we'd be able to wait for all celery tasks to be processed and only then send an email ! scope lift is working on it -> but I'm not sure how we'd actually do this

• [x] gitcoin dev fund grant contribution email shows contributing 5 SAI when I actually contributed 0.15 DAI https://zkscan.io/transactions/sync-tx:484dd93f81ab2de7f2bd0da457b11bc8b8fdc6138d3dffb36495e94bde1801a3

aditya: reverting the 1 mail -> multi contribution PR would fix this

[octavioamu]

• [x] related grants need pagination and layout

[owocki]

• [x] i dont think the 'anonymize my contribution' is working. i just checked the box + made a contribution and it showed up in the feed/transaction list as being from me. ( https://bits.owocki.com/jkuYymEA ) it should show the gitcoinbot in those places instead (grants/tasks.py:182 is supposed to do this)

[owocki]

i just got 8 emails from making 8 contributions in 1 cart. is the bulk checkout email going to make it in?

aditya: Doubtful ! Given that subscription creation happens in celery. I'm not sure how we'd be able to wait for all celery tasks to be processed and only then send an email ! scope lift is working on it -> but I'm not sure how we'd actually do this

[owocki]

• [x] the responsive design on the banner looks really bad. https://bits.owocki.com/04uNkRKG

the banner should be < 300 px high on mobile, 400px on tablet, etc...

[mds1]

zkSync Checkout: Tried contributing 0.5 DAI to two grants with optional tip, got a "Transactions batch summary fee is too low" error tx | error @mds1

@willsputra I noticed this also and messaged the zkSync team about it a few hours ago. We haven't been able to figure out how to reliably introduce it, so their checking the server for bugs on their end. They're also updating the UI with two changes:

1. Show a minimum fee and recommended fee. Minimum is what may sometimes cause this bug. Recommended is ~1 cent higher and never will
2. If this error happens, prompt the user with a button to continue checkout (this will pull the updated correct fee from the server)

zkSync Checkout: Are "Grants Round 8+ Dev Fund" and "Grants Round 7+ Development Fund" different? Current optional tip goes to "Grants Round 7+ Development Fund" screenshot

Good catch. Let me get a PR in to fix this

[owocki]

• [x] on the collections view ( https://gitcoin.co/grants/collections?collection_id=2 ) we dont need to show all the diff grants rounds https://bits.owocki.com/jkuYy8xE
• [x] similarly on the category browsing view ( https://gitcoin.co/grants/tech? ) we dont need to show grants rounds unrelated to that category. it just takes up a full page of space without adding any value (and its not relevant to the category being browsed)

[octavioamu]

• [ ] you can add a video on grant edit but not on grant creation.

[octavioamu]

how the banner should work for mobile? I can reduce but that banner doesn't seems to work for mobile.

[owocki]

• [x] Related Grants takes about 15s to load on this grant https://gitcoin.co/grants/524/clrfund
• [x] On the same grant, the h1 h2 h3 text looks funny bc it is larger than the grant title text ( screenshot: https://bits.owocki.com/BluQEvBn ) . it would be better if the grant desc h1 was always smaller than the grant title
• [x] a bunch of grants in the dapp tech category say they are "not in an active CLR round" on the carts. screenshot: https://bits.owocki.com/o0uqxLEO - even though they are in the dapp tech category. aditya: wait for the CLR estimate to complete and it should turn up. just checked and it was assigned
• [x] this grant detail page takes 8s to load

kevinowocki@local /Users/kevinowocki~ % time curl https://gitcoin.co/grants/86/gitcoin-grants-round-8-dev-fund > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 6605k  100 6605k    0     0   789k      0  0:00:08  0:00:08 --:--:-- 1657k
curl https://gitcoin.co/grants/86/gitcoin-grants-round-8-dev-fund > /dev/null  0.04s user 0.04s system 0% cpu 8.393 total

here is the trace for the same https://bits.owocki.com/Z4uqzNAJ

[octavioamu]

• [x] banner is 814px taking all the screen height making the experience bad @PixelantDesign

[owocki]

@octavioamu i trust your judgement about how to resize the banner on mobile. i agree with your comment about the need to make it larger than it is in your screenshot

[octavioamu]

with the current banner design I don't see a way to fit it on a small screen more than showing the center or just making it small. Banner need a redesign to fit not more than 400 px height, in that way we can reduce it without losing information.

[owocki]

• [x] on the grant details page of https://gitcoin.co/grants/149/rotki-the-portfolio-tracker-and-accounting-tool-t on this module https://bits.owocki.com/L1uOYE77 (1) contributors is spelled wrong (2) it should show the amount raised this round + num contributors this round, not total round contributors. @octavioamu

[octavioamu]

@owocki is using positive_round_contributor_count as the old one 🤔

[owocki]

then why does it show 233 Contributiors for a round that started today

[octavioamu]

seems the api is returning that 233 on positive_round_contributor_count https://gitcoin.co/grants/v1/api/grant/149/ there are 2 dapp clrs probably that is the reason, one yes started today, the other on september. https://gitcoin.co/_administrationgrants/grantclr/

[vs77bb]

• [x] adding comma's here, also design wise -- would it look better 2x3 stacked instead of 1x6?

aditya: added comma here + limited this to landing page. Defer to @PixelantDesign cause we did bring this up during dev

[owocki]

cb4b75f13a0e2a1169fb26fde3f2cd2336858448 fixes the positive contributor count issue

[corydickson]

i just got 8 emails from making 8 contributions in 1 cart. is the bulk checkout email going to make it in?

aditya: Doubtful ! Given that subscription creation happens in celery. I'm not sure how we'd be able to wait for all celery tasks to be processed and only then send an email ! scope lift is working on it -> but I'm not sure how we'd actually do this

I think I've resolved the issue with celery using chords see: https://github.com/corydickson/web/tree/cd-bulk-email-cart and https://docs.celeryproject.org/en/stable/reference/celery.html#celery.chord

Before we were passing around the subscription that was created in the task, and now there is a bug retrieving the correct subscription when that task is completed, particularly when a user contributes to the same grant twice. When filtering for the correct object I'm using the grant and the contributor profile which is not enough to get the most recently created object. Hence the bug of improper balances being shown in the email.

I most likely have a poor understanding of the data model, any ideas for a unique identifier?

[thelostone-mc]

@corydickson well the unique identifier would be the pk of the subscription ! I'm not sure what else would qualify

[corydickson]

@thelostone-mc yeah retrieving that from each task is difficult as if a single task fails then the email task will receive an empty array

[thelostone-mc]

What you could do is make it into one celery task ! If you contribute to 5 grants -> fire one celery task -> loop through it there and let the code inside task run sync Once all subscriptions are created -> you can fire the bulk email. At that point -> you have access to subscriptions so you can pass those as well and get the email to fire aka no extra query

@corydickson

[apbendi]

• [x] Move Idena verification to an "Beta Testing" section on Trust Bonus
• [x] Remove Idena verification from conditional that shows cart banner for Trust Bonus
• [x] Remove the 25% matching reward for Idena

[corydickson]

@thelostone-mc I. was hesitant to go in that direction in case one of the grants in the cart fails processing as it would block all other contributions from completing. There is also possibly a performance hit since we are no longer parallelizing tasks. If I understand your solution correctly, and you are comfortable with that trade off, I can start working on it

[thelostone-mc]

@corydickson well i think it's alright doing that cause

• the API response will still be quick to the end user
• other contributions being blocked cause of one failing -> we could wrap them out try catch and ignore that exception and continue to process the others
• performance hit will be on the celery worker which is alright -> we can afford to wait there

cc @danlipert

[danlipert]

the performance hit is negligible - its async which is all that matters. Just make the task itself robust against the expected failure here with a try block. @corydickson @thelostone-mc

[vs77bb]

🔵 scrolling bar on project descriptions are cutting off words, a bit more space on the right side would clean it up

[mds1]

• [ ] Redirect not working properly if not logged in. Steps to reproduce:
  1. Open a private tab
  2. Add item to your cart
  3. Click checkout
  4. Login to GitHub
  5. You are redirected to the home page / town square, and not your cart