search

gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 771 forks source link

Can't check out with zksync #8572

Open dankrad opened 3 years ago

dankrad commented 3 years ago

Using Firefox (also tried Chrome) Wallet: Metamask Hardware waller: Trezor

When checking out using zkSync, I can't pay. I can fund my ZK account, and then when I want to make the actual transaction, I have to sign two messages. The first message (Account registration) is fine, I confirm first in Metamask, and then on Trezor, but the second message never makes it to the Trezor after I confirm in Metamask. All popups just close and the application is frozen in this state:

image
mds1 commented 3 years ago

I believe Trezor is not supported by zkSync due to frequent compatibility issues—can you try another wallet? If you're still having issues on the zkSync checkout site, please let their support know!

dankrad commented 3 years ago

Wow, that's a huge disappointment! Why is there no big warning about this before I transfer my funds into the zk rollup?

This is terrible!

I did already join their telegram group and was referred to open an issue here.

mds1 commented 3 years ago

My understanding is that Trezor can be supported, but for whatever reason it's tricky and results in a lot of issues / support requests, so they're removing support for it.

If you are able to connect your Trezor at https://wallet.zksync.io/, you could transfer the funds to another wallet's address and complete checkout that way. If you can't do that, your best bet is probably to ask them about the easiest/cheapest way to resolve this issue.

It seems this is an issue on the zkSync side though, since the deposit occurs on their checkout page, so I'm unsure why you were referred to open an issue here. I'll reach out to them and try to find out more

StanislavBreadless commented 3 years ago

Hi @dankrad ! I'm a member of the Matter Labs team.

It seems like the main reason for the issue is that there are two message signatures in a row and the Trezor & Metamask combination can not catch up.

You can still donate via zkSync the following way: open https://wallet.zksync.io/ go to "transfer". Then you will be asked to unlock the account. This is the same as registering the public key. You will be prompted to sign some binary data (we decided to sacrifice readibility in the wallet for a cheaper price, in the future this is likely to be replced with the same readable text as on the Gitcoin round).

After the account unlock is done, you can donate in Gitcoin with a single signature (no public key registration required).

The issue with Trezor has been found recently and it was decided to remove support for the wallet until we are sure that it can be used without harm to UX. The support has not been removed yet, but it will be removed today.

EDIT: The easiest and the recommended approach would be to transfer the funds to your Metamask account via wallet.zksync.io as it should not have any troubles with Trezor. And then donate via this account.

dankrad commented 3 years ago

Thanks, your suggestion of activating it first via wallet.zksync.io worked.

dmihal commented 3 years ago

Just ran into the same issue, spent 20 minutes re-trying, assuming I was doing something wrong.

I'd suggest a warning, either on Gitcoin or the ZKSync wallet alerting users of this issue & linking to the workaround

keriat commented 3 years ago

@dmihal Hey, David 👋

How are you? How things're going alongside the issue with your Trezor 😬? Hope you're safe and and doing good!

My name is Serge, member of the ⚙️ zkSync's Core Team.

Just wondering if you can share more details of the issue you've faced? Maybe you've done any screenshots or took a closer look at the Developer's Console? Any details from your side could be really helpful!

You can leave your feedback here (just tag me) or mail it to me at s.beresnev@matterlabs.dev

Thanks in advance!