gitcoinco / web

Grow Open Source
https://gitcoin.co
Other
1.78k stars 771 forks source link

Implement the Funder's Hall of Fame page #9413

Open zlsgh opened 3 years ago

zlsgh commented 3 years ago

User Story

As a user interested in funding open source development, I would like a "Funder Hall of Fame" page with a breakdown of who are the top matching partners and individual donors on the Gitcoin platform, so that I can learn more about these partners/individuals.

Description

Gitcoin has had a large number of partners and donors over time and it would be great to show them off in one centralized place. The designs have already been created and can be found here. This task is to take these designs and assets and implement them in our application.

Definition of Done

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.07 ETH (239.73 USD @ $3424.69/ETH) attached to it.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 4 weeks, 1 day from now. Please review their action plans below:

1) jdevstudios has applied to start work _(Funders only: approve worker | reject worker)_.

I will gather contribution data from the Gitcoin Rest API and sort the individual donors and partners according to their contribution sizes and also get the list of contributor social info from the Rest API.

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 3 years ago

@nutrina Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

nutrina commented 3 years ago

This is currently still WIP. I have pushed my changes to a branch on a fork of the web repository: https://github.com/nutrina/web/commit/47e522b867da94e9723d5904d669f1517042347c

@zacheryschiller it is not clear to me, shall I submit a WIP PR?

nutrina commented 3 years ago

I have update the PR earlier today. @thelostone-mc I would appreciate if you could give me some feedback.

Currently the Travis build is failing, I will look into that and fix this. And the mobile version of the page is not yet implemented.

Another thing I have noticed is that there are other more 'static' pages that rely on data from a DB, like the ones in the "Whats Possible" menu. These use data from a JSON data structure that is laoded from the DB. My question: how do you maintain this cotent? I would expect this to be rather difficult to maintain ...

This is why I have created a separate data model, after discussing this also with @thelostone-mc , and you can edit this from the admin view.

Normally for such usecases I would look at frameworks like Wagtail (https://wagtail.io), a CMS build on top of django. I don't know if you have considered this already, but I believe this would make handling pages like the "Hall of Fame", and other pages for marketing for example much easier.

I will continue later looking into the faild build and working on the open points.

nutrina commented 3 years ago

@zacheryschiller, @thelostone-mc Travis seems to fail due to this:

Coverage.py warning: Couldn't parse Python file '/home/travis/build/gitcoinco/web/app/dashboard/apps.py' (couldnt-parse)

This error also exists on the master branch. The error is:

  File "app/dashboard/apps.py", line 33
    import .signals # noqa
           ^
SyntaxError: invalid syntax

But this seems to have been in the code for ages. Do you know about this?

nutrina commented 3 years ago

I have updated the request.

There is 1 minor open point:

I am looking forward for your feedback.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.07 ETH (227.28 USD @ $3246.9/ETH) has been submitted by:


PixelantDesign commented 3 years ago

@nutrina could you post a video? Thank you!

nutrina commented 3 years ago

@PixelantDesign sure, Here it is: https://drive.google.com/file/d/1Timptsv1ZIwbQKl5GKfkyJfFWvdEu02C/view?usp=sharing Please don't mind that the images for top matching partners and donors are of bad quality - these I have cut out from a screenshot of the design. Proper quality images will be uploaded in production.