GR11 Feedback

[octavioamu]

Internal feedback ticket

still working on fixes for:

• [x] landing grants collections
• [x] filters styles
• [x] mobile filters
• [x] and other general things

[willsputra]

Thanks for this! A few feedback, other than the filter styles that you're working on:

• [x] The new Discover section on grants landing doesn't seem to work. When I clicked on Undiscovered Gems, it still brings me to Weighted Shuffle view. There seems to be two sorts in the url?

• [x] When I add Region filters, it seems like the numbers on More Filters are changed too

• [x] After clicking Apply on the filters, we should close the filter popup. Example airbnb:

• [x] Me menu > My Grants > Projects doesn't seem to work (grants that aren't mine are still showing)

• [x] Are we going to make the cart sticky? Design:

• [x] ~We should show how many grants are added to cart in the sidecart. Design:~ https://user-images.githubusercontent.com/19514207/131728748-fd46702a-909a-4820-8679-af2764546464.png

• [x] ~If I scroll down to page 2 and do a reload, I can only see page 2 grants~ https://user-images.githubusercontent.com/19514207/131731978-562bf971-e77b-465f-97c4-64d020872e00.png

[abitrolly]

https://gitcoin.co/hackathon/gr11/onboard the link to wiki page https://gitcoin.co/wiki/grants/ is 404.

[abitrolly]

And it would be nice to get these implemented before GR11 starts. As I've messed up a Twitter handle in my submission.

• https://github.com/gitcoinco/web/issues/8876
• https://github.com/gitcoinco/web/issues/7222

[frankchen07]

• [x] looks like some of the filter menus pop up and some pop down, bug, or intended?
  • https://user-images.githubusercontent.com/7516920/131763527-d5c05a5a-a92d-4c8d-8287-b7f196dc1947.png
  • https://user-images.githubusercontent.com/7516920/131763538-251ffd0a-7ab0-4bae-97bd-1fa86df431df.png
  • https://user-images.githubusercontent.com/7516920/131763543-62a34582-dc80-4056-8813-5ffa9773e1e0.png

Aditya: this has been fixed

[frankchen07]

• [x] search bar functionality does seem to work? I was looking for "kyle land" to see if it would single out the one grant currently in view, but it doesn't seem to do anything when I hit enter https://user-images.githubusercontent.com/7516920/131763766-69ccfbf3-17ea-432a-abb8-a5eaf550d6c9.png

Aditya: this has been fixed

[PixelantDesign]

Lookin' good! Feels smooth and fast.

Aside from some of the items mentioned above...

• [ ] When filtering term didn't match, there is no feedback on the page (this might still be wip still). Aditya: could you share design for this?

• [x] New cart menu, it wasn't apparent that there were more grants to see, I saw 4 grants but the checkout button said 9 grants, consider displaying scrollbar by default) https://user-images.githubusercontent.com/238235/131765745-f52c2536-a1bd-4e8d-b4c4-1482c5b7ee25.png Aditya: Octo fixed it

• [x] When in checkout page I was able to click remove a grant from the new cart menu, but the item was not removed from the actual checkout page and the number of cart items in checkout page did not reflect.

• [ ] ~After creating a collection from the cart, return the user back to their cart instead of explorer.~ Aditya: not a bug, if we want to change it , let's do it in a follow up ticket

• [ ] ~After user adds a grant to their collection, display the collection that Grant has already been added to.~

  

  Aditya: not a bug, need more context -> maybe a follow up ticket

[octavioamu]

~wrong filter condition probably when empty https://stage.gitcoin.co/grants/cards_info?page=1&limit=6&sort_option=weighted_shuffle&network=mainnet&state=active&collections_page=1&grant_types=&grant_tags=&tenants=&idle=true&sub_round_slug=gr11-uniswap&round_num=1&customer_name=Uniswap&tab=grants probably due a grant without any tag selected https://stage.gitcoin.co/_administrationgrants/grant/3/change/~

Aditya: The filter was not set right in DB. It should be {"tags": "1"}

[octavioamu]

• [x] missing landing featured collections

[octavioamu]

• [x] filter my collections from menu doesn't work, query need to be changed to be parameters

[octavioamu]

not handling api server error messages

[thelostone-mc]

• [x] ensure page param is reset to 1 on applying any filter
• [x] enure URL param of types, tags, tenant is loaded as an array and not string when only 1 value is present
• [x] fix dropdown auto-flip
• [x] create rounds
  • [x] on staging
  • [x] on live
• [x] set twitter keys
• [x] remove twitter feed posting
• [ ] setting banners

[willsputra]

When filtering term didn't match, there is no feedback on the page (this might still be wip still). Aditya: could you share design for this?

@thelostone-mc @octavioamu tagged you with the empty state designs on GR11 Figma!

[willsputra]

tried creating grants: https://stage.gitcoin.co/grants/11/grant1-with-gaming-wallet-tags https://stage.gitcoin.co/grants/12/grant2-with-daos-tag

• [x] tags don't show up in grants detail page
• [x] my grants don't show up on my profile (Grants tab is missing and there's nothing in the Activity)

[octavioamu]

• [ ] change bg politicities to match new params patterns

[willsputra]

UI / styles tweaks (will keep updating this post for UI/styles stuff):

• [x] Desktop: When one or more filters are active, they go to the new line. Consider increasing the space for the filters to be more than 50% width. If needed, we could also make the search bar shorter (since it will expand anyway when people click on it).
• [x] Add search icon to search bar
• [x] Add more space between round title ("GR11 - Community") and filters
• [x] Add more space between each option on More Filters (right now "Grants I've contributed to" is closer to "My Grants" than "My Contributions")

[frankchen07]

• [x] the round buttons look slightly cut off on the top and bottom

• [x] also create a grant when clicking on it

the checkout buttons look funny, what's the random purple square?

[owocki]

all testing done on chrome/osx with metamask

• [x] layout is funny on amount raised here => https://bits.owocki.com/04uxLNbb

• [x] when i click apply nothing happens https://bits.owocki.com/9ZuQD0GB

• [x] add all to cart button doesnt work => https://bits.owocki.com/Wnu0ql4R

• [x] sort by select box should have a hover cursor on it not a text curosr https://bits.owocki.com/lluo6n10

• [ ] cannot test related grants or contributions (or contributions not working) despite this grant having had funding on it https://bits.owocki.com/P8uG6mWK

• [x] if i add 4 grants to my cart on this page ( https://stage.gitcoin.co/grants/explorer/?page=1&limit=6&sort_option=-metadata__gem&network=mainnet&state=active&collections_page=1&grant_types=&grant_tags=&tenants=&idle=true&tab=grants ) then i go to the carts page, only 2 grants show up in cart

https://bits.owocki.com/eDuRlw6B https://bits.owocki.com/rRubN09g

• [x] the back button on the grant doesnt ever seem to update https://bits.owocki.com/P8uG6kO2 everytime i browse a category or a collection it should be updated.

• [x] when i go to checkout on standard checkout i get an insufficient dai balance error ( https://bits.owocki.com/xQu6zYD8) even tho i have plenty of DAI in my wallet

• [x] on polygon checkout ( https://bits.owocki.com/7KuEqbq2 ) , itd be nice to give the user a link to polygon support so they dont have to fish for it. itd alos be nice to let the user know they need MATIC (not just DAI) to checkout on the matic chain. #9430 & https://github.com/gitcoinco/web/pull/9421/commits/eb5b3a82251a6a4355cdf1c4d4a1f9c548955dd1

• [x] when i swtich my network to polygon i get this error https://bits.owocki.com/12uv0o5b

• [x] when i try to checkout on polygon, it just hangs for a minute and then i get this error when the txn clears. https://bits.owocki.com/KouJYdze

• the txn shouldnt fail

• there should be a pending txn indicator on the UI

• [x] if i click on 'community' from https://stage.gitcoin.co/grants/13/owocki-stuff it takes me to https://stage.gitcoin.co/grants/explorer/Community?page=1&limit=6&sort_option=weighted_shuffle&network=mainnet&state=active&collections_page=1&grant_types=&grant_tags=&tenants=&idle=true&tab=grants which does not actually filter on community grants

• [x] why is there a random ether logo floating over here? https://bits.owocki.com/9ZuQD09Z what does this mean? theres no label, no descriptor, no alt text. what is it? its bugging me.

• [x] on the grants checkout, the spacing on the buttons should have some padding https://bits.owocki.com/L1urWdYP

• [ ] when i try to connect with idena i get this error https://bits.owocki.com/qGuJrlQP might be a staging issue thing tho? Aditya: yup staging configuration issue

• [ ] i ran out of time testing all the trustbonus tabs at https://stage.gitcoin.co/owocki/trust (did brightid, POH, idena). but itd be ncie if someone could verify they all work. Aditya: no changes made here, works

• [ ] did not get a chance to test emails either. since stage doesnt support it. has anyone tested those? have they been updated with info about polygon checkout, etc? Aditya: Yes, local mails were triggered

• [ ] is there a way to test with a matching campaign live? Aditya: what is this ? more context needed

• [x] it's hard to test any QF functionality with an ENV that doesn't have any QF rounds going Aditya: @gdixon has been testing them in live + staging + local. Confident here

[octavioamu]

@willsputra how did you created this 2 grants? seems are without tenant that the reason on showing up on the cart since not eth grants and not indication of other tenant

[octavioamu]

• [x] grant address field on form accepting any random character

[willsputra]

@willsputra how did you created this 2 grants? seems are without tenant that the reason on showing up on the cart since not eth grants and not indication of other tenant

hmm I chose ETH on the create grant form, although I think I put "0x0" on the recipient wallet address field

[octavioamu]

hmm I chose ETH on the create grant form, although I think I put "0x0" on the recipient wallet address field

• [x] Lol that is the issue 0x0 is the "default" on our form so actually is taking as not ethereum grant, this land into my latest comment here we need to validate the address

[frankchen07]

didn't we change the language and functionality to be a % on top of their original contribution?

[PixelantDesign]

Explorer List view

• [x] $0 out of alignment on card

[octavioamu]

$0 out of alignment on card

that is due to the other bug on the form not having validation on address then not getting tenant, as there is not icon with the chain the template create that break

[octavioamu]

when on cart page if you decide to create a collection then you get redirected , this shouldn't happen as we don't even know if the user want to go to another place, maybe he just want to checkout next

[octavioamu]

• [x] Missing filtering parameters on collection tab to get my collections from the me menu on nav query : https://stage.gitcoin.co/api/v0.1/grants_collections/?profile=35

[PixelantDesign]

when on cart page if you decide to create a collection then you get redirected , this shouldn't happen as we don't even know if the user want to go to another place, maybe he just want to checkout next

agree @octavioamu, lets keep the user in the checkout page after collections creation is complete.

[PixelantDesign]

from @owocki comment

why is there a random ether logo floating over here? https://bits.owocki.com/9ZuQD09Z what does this mean? theres no label, no descriptor, no alt text. what is it? its bugging me.

The intent was to denote what chain that grant accepted payment on. This is a confusion point for users as well. We could add a tooltip to clarify that. Thoughts @octavioamu ?

[owocki]

per the team call today, make sure we test the new endpoints with productionlike data pls. if a grant with 10k contributions takes several seconds to load, that ll be a problem when the code hits prod

[Kweiss]

Looks like most of the "sort by" are not working:

• [x] Selecting "Oldest Grants" and "Updated Recently" are two example, but its most of them not working.
• [x] When I apply filters, the Title fo the first grant drops a line (like an extra
  is added?) T shirt Grants only looks like this when a filter is applied. https://cloudup.com/c2-QtRabXcF
• [x] With Uniswap side round selected, the "Clear" button drops a line and it shouldn't : https://cloudup.com/ctsOr7olNOJ

[octavioamu]

• [x] Reverse Pagination
• [x] Remove add-all
• [x] Organise the filters/sort bar
• [x] Reset page to 1 for sorting
• [ ] Contributors email
• [x] Gas estimations
• [ ] Include gas price in checkout recommendation
• [ ] Cart page work
• [x] fix the collections image source
• [x] reintroduce collections to the landing
• [ ] Replace CLR function with clr3.py
• [ ] Ensure banner matches latest version of figma (with category bar above banner)
• [ ] Run through optimisation stuff (asset servers loadbalancer && a replacement celery4)
• [ ] Turn on the crontabs for celery servers
• [ ] Validate CLR (UNISWAP)
• [x] Update CLRs links on landing to use a querystring instead of a path

[PixelantDesign]

• [x] Grants Home page - Clicking on the mini clr banner (uniswap) does not map to the filtered view (for uniswap) on the explorer.

[Kweiss]

• [x] Grants checkout not working on Rinkeby during testing - https://cloudup.com/coh7mEglojT

• [x] Some grants not in the round are being displayed in the grid view (explore grants) when they shouldn't be. For example, I clicked the GR11 - Community banner (https://cloudup.com/caON-W3MQ21) and in the view it showed two grants that were not eligible. This should not be in the view. https://cloudup.com/i7tmWT0l57o

• [x] If I edit a grant, and change the image - the original image goes fuzzy, but my new image does not load in that window. There is no confirmation the change completed. It is not until after I save my changes, then hard refresh the grant itself does the new image show up. I believe the new image should replace the existing image once uploaded. https://cloudup.com/cCvoNxF-OSH Aditya: could you try refreshing and trying again. Tried it on staging it and it works SEE GIF

• [x] The Amount raised is indented slightly if the Grant is in CLR round and it should not. It should still be aligned. see screenshot - https://cloudup.com/c7aBp2oXtdh

• [x] ~The grant branding routing policy does not seem to be working - perhaps because the URL changed so much? I cant get the Uniswap banner to show up properly on the round.~ GrantRoundingPolicy was configured wrong

[Lerog1724]

Good day, should I return the old address or I'll be sticking with the metamask?

Rogeljoanclitonkevin17242111$$$

On Fri, Sep 3, 2021, 9:44 PM Pixelant @.***> wrote:

from @owocki https://github.com/owocki comment

why is there a random ether logo floating over here? https://bits.owocki.com/9ZuQD09Z what does this mean? theres no label, no descriptor, no alt text. what is it? its bugging me.

The intent was to denote what chain that grant accepted payment on. This is a confusion point for users as well. We could add a tooltip to clarify that. Thoughts @octavioamu https://github.com/octavioamu ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gitcoinco/web/issues/9422#issuecomment-912551370, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS73BNVENEXYMC5S74MW3WLUADGNHANCNFSM5DHD2EYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[PixelantDesign]

• [ ] In the cart dropdown, it felt unnatural to not be bale to click on each grant to go to the detail of the grant. Can we consider linking and opening those grants in a new window?

Cart dropdown - no link on each grant

Checkout page - link exists for each grant

Aditya: Let's have this as a new ticket.

[PixelantDesign]

• [x] Need to set an image constraint here Octavio: follow the size specs and all with the same ratios and all will be fine

  

• [x] Create Form - If user is unable to freely create tags, we should update the Sorry message to say "Please select from the list of tags below". Octavio: create tags isn't part of the scope

  

[octavioamu]

Guys if you have something not related to the changes we did on the sprint and is not a blocker please create a separate ticket.

[willsputra]

testing on prod:

• [x] tag filter: can't see the Clear and Apply button since the list is very long. maybe add either scroll or tag search?

• [x] filters: checkmark is missing on checkboxes

  

• [ ] polygon checkout: got this error while trying to checkout with polygon

  

[PixelantDesign]

• [ ] when no filters are selected, the clear option is still present, when there is nothing to clear

  

• [ ] alignment issues: buttons bumping into each other on mobile number of grants and sort by not properly aligned

  

• [x] on mobile user can't get to the bottom of the full list of tags, can we consider a scroll bar within the dropdown?

  

[PixelantDesign]

• [x] NFT category might not be hooked up to the right banner, showing explorer default banner - on chrome and brave

Brave

[octavioamu]

Closing for bug reports create a new issue or use internal CS-L2