lthrift
commented
2 years ago Is this done @GTChase ?
Open frankchen07 opened 2 years ago
lthrift
commented
2 years ago Is this done @GTChase ?
GTChase
commented
2 years ago @lthrift this is not done.. Talking to @gdixon we determined that this is a huge lift and would provide little return on that investment given that things are currently working as expected.. The original concern was with EIP-1559, which has been merged and things are currently working as expected..
The next concern we have where this comes into play again is the merge of the beacon chain which is happening sometime later this year.. This merge is already on Rinkeby so we can do some early validation on if and how much the merge would impact us without doing this upgrade.
lthrift
commented
2 years ago no problem - thanks for the update! I just wanted to close it out if it was a duplicate of something completed already.
Lindsey Thrift, VP of Product LinkedIn https://www.linkedin.com/in/thriftlindsey/ | Telegram https://t.me/lthrift https://gitcoin.co/
On Thu, Mar 10, 2022 at 7:29 AM GTChase @.***> wrote:
@lthrift https://github.com/lthrift this is not done.. Talking to @gdixon https://github.com/gdixon we determined that this is a huge lift and would provide little return on that investment given that things are currently working as expected.. The original concern was with EIP-1559, which has been merged and things are currently working as expected..
The next concern we have where this comes into play again is the merge of the beacon chain which is happening sometime later this year.. This merge is already on Rinkeby so we can do some early validation on if and how much the merge would impact us without doing this upgrade.
— Reply to this email directly, view it on GitHub https://github.com/gitcoinco/web/issues/9757#issuecomment-1064123246, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWA66JFSCRPMLIIM2HCVNZDU7IBMVANCNFSM5I5552OQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Description
In order to take advantage of the London fork, we need to upgrade web3.py to the latest version (5.22.0)
Some work on migrating v4 -> v5 has already been undertaken here (by developerfred): https://github.com/gitcoinco/web/pull/6366
However, developerfred was working to upgrade web3.py to 5.7.0 (back in April of 2020) and it's likely that many things (especially with regards to the London fork) will not have been implemented.
The team believes it would be better to start a fresh branch and to make all of the required changes again using #6366 as a guide (along with the migration guide found here).
Upgrades will need to be made against any script that utilises web3.py:
Acceptance Criteria
When all scripts utilising web3.py have been checked and updated according to the migration guide and all regression tests pass