gitconsensus / GithubOrganizer

Github App for making Organizations easier to manage
https://organizer.gitconsensus.com/
MIT License
36 stars 11 forks source link

Not seeing changes updated to an organization #33

Open Julian opened 1 year ago

Julian commented 1 year ago

Hi there! Hope all's well.

We've/I've been trying to evaluate using GithubOrganizer for the JSON Schema projects. Thanks for writing it!

I seem to be having difficulty getting it set up. I first was trying to follow the instructions to use the normal hosted GitHub app. After creating a testing GitHub organization with a few test repostiories and creating a organizer.yml which I think should be valid? I didn't notice the GitHub app making any changes to repositories, they all stayed with their default settings.

I've tried now to instead download and run the CLI myself (after creating a testing GitHub App, generating a private key, and giving it whichever permissions made running the CLI succeed without a traceback).

But I still don't see changes to the organizer.yml show up. Somehow it does seem to have modified the labels once (to create the label) but it doesn't seem to reliably update them as I change the organizer.yml. If I say, add a new label and push (which I've done), then running the CLI doesn't create the new label. Or if I enable wiki's on all repos, the same, I don't see the setting modified.

Maybe I'm missing something, let me know if so! A sample CLI run is below, where I've done what I just mentioned (added a label and changed the wiki default setting), which seems to complete successfully, but hasn't made any changes I can see:

``` /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/github3/session.py:3: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working from collections import Callable /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/github3/structs.py:11: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working class GitHubIterator(models.GitHubCore, collections.Iterator): Configuring all repos in julian-testing-organization-om. Updating the settings of repository julian-testing-organization-om/.github. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the labels of repository julian-testing-organization-om/.github. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the dependency security settings of repository julian-testing-organization-om/.github. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating branch protection for main in julian-testing-organization-om/.github. {"required_status_checks": {"contexts": [], "strict": false, "required_approving_review_count": 1}, "enforce_admins": false, "required_pull_request_reviews": null, "restrictions": null, "required_linear_history": false, "allow_force_pushes": false, "allow_deletions": false} /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the settings of repository julian-testing-organization-om/example_repo. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the labels of repository julian-testing-organization-om/example_repo. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the settings of repository julian-testing-organization-om/another_repo. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the labels of repository julian-testing-organization-om/another_repo. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the dependency security settings of repository julian-testing-organization-om/another_repo. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating branch protection for main in julian-testing-organization-om/another_repo. {"required_status_checks": {"contexts": [], "strict": false, "required_approving_review_count": 1}, "enforce_admins": false, "required_pull_request_reviews": null, "restrictions": null, "required_linear_history": false, "allow_force_pushes": false, "allow_deletions": false} /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the settings of repository julian-testing-organization-om/last-one. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the labels of repository julian-testing-organization-om/last-one. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the dependency security settings of repository julian-testing-organization-om/last-one. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating branch protection for main in julian-testing-organization-om/last-one. {"required_status_checks": {"contexts": [], "strict": false, "required_approving_review_count": 1}, "enforce_admins": false, "required_pull_request_reviews": null, "restrictions": null, "required_linear_history": false, "allow_force_pushes": false, "allow_deletions": false} /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the settings of repository julian-testing-organization-om/foo. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the labels of repository julian-testing-organization-om/foo. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating the dependency security settings of repository julian-testing-organization-om/foo. /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback Updating branch protection for main in julian-testing-organization-om/foo. {"required_status_checks": {"contexts": [], "strict": false, "required_approving_review_count": 1}, "enforce_admins": false, "required_pull_request_reviews": null, "restrictions": null, "required_linear_history": false, "allow_force_pushes": false, "allow_deletions": false} /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback /Users/julian/Desktop/asdf/venv/lib/python3.9/site-packages/celery/app/task.py:393: ResourceWarning: unclosed return self.run(*args, **kwargs) ResourceWarning: Enable tracemalloc to get the object allocation traceback ```

(n.b. there was a small bug I saw which is that runs of the CLI blew up if they encountered an empty repository with no main branch as trying to access branch protections obviously doesn't work in that case. So I've since ensured my testing repositories are indeed not empty now, so the CLI runs.)