search

gitdagray / csv-to-sql-insert

Provide table data as a CSV (comma-separated values) file and output a SQL insert statement for a table with the same name as the file.
MIT License
97 stars 122 forks source link

Add testing with jest #4

Open gitdagray opened 10 months ago

gitdagray commented 10 months ago

Add jest and write tests.

Maanu07 commented 10 months ago

Hey David, sure I will work on this tomorrow.

leonardogattidev commented 10 months ago

I'd like to suggest using Vitest instead of Jest, in general, it's nicer, faster and lighter, also, it's API is Jest-compatible. [Why | Comparison | Size: Vitest - Jest]

Maanu07 commented 10 months ago

I'd like to suggest using Vitest instead of Jest, in general, it's nicer, faster and lighter, also, it's API is Jest-compatible. [Why | Comparison | Size: Vitest - Jest]

I agree, but I think using Vitest make much sense if you are using vite as your tool, but since our this application is entirely nodejs based and I think there will be not much things to tests, so it won't be a bad idea to use jest instead. Do let me know what you say?

leonardogattidev commented 10 months ago

Even outside of projects using Vite, those advantages still stand, and, I'm unaware of any known problems with it (do let me know if there are any).

Still, feel free to use what you're comfortable with, the difference is not that big and may not be worth the trouble, the configuration (file) is different from Jest, so that would be one more thing to learn, also, due to Jest being more battle tested it may be easier to find documentation if things go wrong.

godwintrav commented 2 months ago

HI @gitdagray Has this been done? I dont mind working on this and adding the test