search

gitdagray / csv-to-sql-insert

Provide table data as a CSV (comma-separated values) file and output a SQL insert statement for a table with the same name as the file.
MIT License
97 stars 122 forks source link

prettier and eslint config for the project #7

Open YugandharrPatil opened 10 months ago

YugandharrPatil commented 10 months ago

I think adding a prettier and eslint config for the project would be ideal since varying configs of users can make it difficult for changes to be analyzed in PRs.

gitdagray commented 10 months ago

This is a good idea and one I'd like to prioritize so all the PRs aren't formatted differently.

gitdagray commented 10 months ago

Prettier config now added - see dev dependencies in package.json. Guide for this update here: https://gist.github.com/siakaramalegos/4a5cdab1f44ffb217a48d5260043f8ae

eslint config still needed - leaving this issue open.

YugandharrPatil commented 10 months ago

how about we go with the infamous airbnb config? Here's the style guide: https://github.com/airbnb/javascript

gitdagray commented 10 months ago

how about we go with the infamous airbnb config? Here's the style guide: https://github.com/airbnb/javascript

Yes, I've looked at that in the past. Please do. 😀

YugandharrPatil commented 10 months ago

How about we populate the prettier config? Because it'll keep giving errors until we populate it with something. Safe to close the issue after its addition I guess.