search

gitdalisar / mod-Faction-Free

Faction Free is a WOTLK 3.3.5a (Azerothcore base) selection of files to allow a player to interact with opposite factions to have access to those corresponding reputations, quests, and achievements.
GNU Affero General Public License v3.0
11 stars 1 forks source link

[FEATURE] - Add cross-faction trade/buffing outside of group #8

Closed gitdalisar closed 5 months ago

gitdalisar commented 5 months ago

Is your feature request related to a problem? Please describe. No, this is not related to a problem. The method that cross-faction operates in Azerothcore is through the worldserver.conf settings. This appears to override the allowance of being in a group or raid together and then that allows for cross-faction features to appear.

Describe the solution you'd like It would be good to have the trading and buffing allowed for cross-faction play OUTSIDE of being in a group first to make those features work.

Describe alternatives you've considered There are not really any workarounds to this due to the limitations in place for factional game play. Will likely need to modify .cpp files to get this to occur, if it is even possible. Will need to research exactly where those worldserver.conf settings get taken into consideration within the source code and then either modify or remove the checks for faction to allow this to occur.

Additional context Initially reported by Ghost via DM in Discord.

gitdalisar commented 5 months ago

So cross-faction trading and follow outside of a group is a no go. Looking through other Git issues for the main distros (Azerothcore, Trinity, Mangos) this is something that was coded into the client.exe apparently back in TBC at some point. So if this were purely Vanilla, maybe, but since it is now in WOTLK looks like this isn't possible without like an open source client being built. I'll look into the buffing, but that may be the same.

gitdalisar commented 5 months ago

Looking more into this, to cast spells on players of opposite faction outside of your group, this may cause a LOT of unintended behavior. Within the targets you can pick for a spell you do have TARGET_UNIT_TARGET_ALLY or TARGET_UNIT_TARGET_ENEMY typically for buffs/damage accordingly. There does NOT seem to be a TARGET_UNIT_TARGET_PLAYER so I think if we open up the ability to heal/buff/etc players outside the faction, it will result in also being able to accidently drop a heal on a boss mid fight... I'll look into it a bit more but do not think this one is going to be doable.

gitdalisar commented 5 months ago

Going to close this and transfer to a new feature request.

Trade is not possible as that is prohibited by the hard faction check within the client.exe. No way around this, must be in a group and leveraging the AllowTwoSides features in the worldserver.conf file.

The spell one may still be plausible. Will add more details on that one.