search

gitenberg-dev / giten_site

django repo for running the GITenberg website
http://www.gitenberg.org
40 stars 5 forks source link

Add properties to the book model #57

Closed bdr99 closed 6 years ago

bdr99 commented 6 years ago

These properties are for use on the search results page. The author property is parsed from the YAML using PyYAML. The title_short and description_short properties are generated dynamically.

bdr99 commented 6 years ago

After some investigation, we determined that the CSS approach to truncating text is only possible for single line text. Since we require multiple lines to be displayed, we will have to stay with the server-side truncation.

eshellman commented 6 years ago

for multiline blocks you can use overflow: scroll;

bdr99 commented 6 years ago

@eshellman We're not too sure if that would look better. Do you think scroll bars are the best way to truncate descriptions?

image

eshellman commented 6 years ago

maybe looks better on the mac; if you fix the width the bottom scroll goes away.

bdr99 commented 6 years ago

@eshellman I have made this change as part of https://github.com/gitenberg-dev/giten_site/pull/58.

eshellman commented 6 years ago

what's with the travis build failing?

bdr99 commented 6 years ago

@eshellman I'm not sure why it's failing, it seems that for some reason it can't find the .travis.yml file. It's strange because the PR that added that has been merged into master.

eshellman commented 6 years ago

should have realized that a pull from master was needed