search

gitenberg-dev / giten_site

django repo for running the GITenberg website
http://www.gitenberg.org
40 stars 5 forks source link

show notification when subscribing to mailing list #59

Closed bdr99 closed 6 years ago

bdr99 commented 6 years ago

Previously, there was no acknowledgment after clicking on the "Subscribe" button to subscribe on the mailing list. This pull request adds a notification message to inform the user that they have now subscribed to the mailing list.

eshellman commented 6 years ago

There's a mailchimp mailing list??? I need to figure out where the list is. Maybe @sethwoodworth has the keys.

eshellman commented 6 years ago

Do you understand why the diff is showing a bunch of things as new that are already in master? As far as I can tell the only real change left is gitensite/apps/content/templates/partials/sign-up-announce.htmldjango

bdr99 commented 6 years ago

Whoops. No I don't. I was trying to rebase the PR so that it would be based on the latest version of master. I ran git rebase master followed by git push. You are correct that gitensite/apps/content/templates/partials/sign-up-announce.htmldjango was the only intended change in this PR.

eshellman commented 6 years ago

So maybe close this PR and start anew with the intended change branched from current master?

bdr99 commented 6 years ago

Closed in favor of https://github.com/gitenberg-dev/giten_site/pull/72.