search

gitenberg-dev / giten_site

django repo for running the GITenberg website
http://www.gitenberg.org
40 stars 5 forks source link

show notification when subscribing to mailing list #72

Closed bdr99 closed 6 years ago

bdr99 commented 6 years ago

This is a redo of https://github.com/gitenberg-dev/giten_site/pull/59 which was incorrectly rebased.

eshellman commented 6 years ago

I'll merge this to be expeditious, but I have two comments:

  1. is it required, or good practice, to set type="text/javascript" on the <script> element?
  2. is there a reason to use a file extension ".htmldjango" as a file extenson? it's not consistent with other templates in this repo.
eshellman commented 6 years ago

deployed to production