giterlizzi / dokuwiki-plugin-datatables

Add DataTables support to DokuWiki
GNU General Public License v2.0
10 stars 11 forks source link

Dokuwiki Datatable plugin broken since last update #12

Closed paulhuysing closed 8 years ago

paulhuysing commented 8 years ago

Updated datatable plugin on 27/10/15 with latest update. Datatable plugin not working now (Release 2014-05-05a "Ponder Stibbons")

Plugin is now not rendering the table as per design spec. No search, sort or other functionality i.e. it just looks like a normal table.

Not sure what other information to provide

mrkslrnz commented 8 years ago

I can confirm that. Have a look here: http://wiki.lrnz.name/doku.php/playground:playground

As far as I understand, jQuery as well as the DataTables JavaScript library get generated into one single DokuWiki JS file which is different from the example page: http://lotar.altervista.org/dokuwiki/wiki/plugin/datatables

On the example page the table gets an ID "DataTables_Table_0" which is attached to the table by JS as it is not inside the HTML but can be seen when inspecting the element.

There I can also see two DataTables css files included in the header which are missing on my wiki page. You also don't seem to have this one compiled JS file but the jquery.dataTables.min.js is included directly.

giterlizzi commented 8 years ago

Hi! I have tested the @mrkslrnz 's code and work, "only" if the page is created outside the "playground" because this namespace is present in the excludedPages setting (default value (wiki|playground)).

Create a test page outside the playground or change the value of excludedPages.

At your disposal.

Best regards, Joseph

paulhuysing commented 8 years ago

The plugin works on your http://lotar.altervista.org/dokuwiki/wiki/plugin/datatables site, so perhaps it only relates to backward compatability with Ponder Stibbons since the latest plugin update?

Attached image is snip of pagesource from lotar.altervista - I can see script being generated to create the table.

image

However in my example, no equivalent script is being generated to create the table.

image

mrkslrnz commented 8 years ago

Sorry, my mistake. I wasn't aware of the excludedPages setting. The plugin works outside the playground page. Thanks!

giterlizzi commented 8 years ago

No problem :)

paulhuysing commented 8 years ago

Update to above issue - Operation of Edittable plugin is also broken so the issues must be related.

Confirmed - Edittable plugin now not compatible with Ponder Stibbons. Upgraded to Detritus - issue resolved

Thank you