giterlizzi / dokuwiki-plugin-datatables

Add DataTables support to DokuWiki
GNU General Public License v2.0
10 stars 11 forks source link

Datatables Not Working with Snippets Plugin #18

Closed rgibsonohmh closed 8 years ago

rgibsonohmh commented 8 years ago

I have a Dokuwiki instance which has the datatables plugin and the snippets plugin.

With both plugins enabled, the popup which supports the snippets dialog is missing some button to preview and insert the various snippets into the edit document.

When I disable datatables, I am able to properly insert snippets via its popup. I can verify this before and after clearing every cache I can find (local browser, DW CSS, DW JS, DW page cache).

I have already reached out to the snippets author and filed a bug report. (https://github.com/turnermm/Updatable-Snippets-for-Dokuwiki/issues/19)

They are seeing the following error:

TypeError: JSINFO.plugin is undefined
if (JSINFO.plugin.datatables.enableForAllTables) {

I have also tried having the datatables plugin setting for all tables both on and off, and I get the same result.

giterlizzi commented 8 years ago

Hi! Thanks for reporting this issue. Which version of DataTables plugin you have ?

Joseph

rgibsonohmh commented 8 years ago

Forgot to include that...

I have 2016-02-23 installed for DataTables and 2016-02-02 for snippets. I have a fully-updated Detritus install.

giterlizzi commented 8 years ago

Thanks! Can you type this in your browser in Developer Console ?

typeof JSINFO.plugin

and

typeof JSINFO.plugin.datatables

rgibsonohmh commented 8 years ago

typeof JSINFO.plugin returns the text 'object'

typeof JSINFO.plugin.datatables returns the same text.

giterlizzi commented 8 years ago

Hi! I have changed the JS. Can you download the lastest version of plugin ?

rgibsonohmh commented 8 years ago

I was out of the office yesterday.

I have since upgraded the plugin to the latest version from the extension manager.

I am happy to report that with the Datatables plugin enable and the Snippets plugin enabled, I can properly insert the snippets.

This issue can now be closed.

Thanks, Rob

From: Giuseppe Di Terlizzi [mailto:notifications@github.com] Sent: Monday, March 21, 2016 7:32 To: LotarProject/dokuwiki-plugin-datatables dokuwiki-plugin-datatables@noreply.github.com Cc: Gibson, Robert rgibson@medcentral.org Subject: Re: [dokuwiki-plugin-datatables] Datatables Not Working with Snippets Plugin (#18)

Hi! I have changed the JS. Can you download the lastest version of plugin ?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_LotarProject_dokuwiki-2Dplugin-2Ddatatables_issues_18-23issuecomment-2D199234133&d=BQMCaQ&c=jNrjsSmnfCqfHLgm02ST0z0kZ0QkbBOxYa-XvWBUOM&r=6Le7KzvaYOsnFAezPw5lvnTZHHoMUvQJp-J0OMaw64&m=CybAnuDMX-eoPZeBtc9bYXm8wTZLzwu-IYRsTiMV7eE&s=m7Z-I8elpohTBpLl2tDGCBIuhHPtGWx_wh1C46OScj8&e=

[http://www.ohiohealth.com/uploadedImages/Fortune100-2014.jpg]

FORTUNE 100 Best Companies to Work For 2007-2014