search

giterlizzi / dokuwiki-plugin-datatables

Add DataTables support to DokuWiki
GNU General Public License v2.0
10 stars 11 forks source link

Conflict with data plugin 2016-03-11 #20

Open coastgnu opened 8 years ago

coastgnu commented 8 years ago

Conflict with data plugin version 2016-03-11?

Hi Joseph,

After updating the dokuwiki data plugin I got a white screen. The only relevant error log I got was the following.

apache2/error.log

[Sat Apr 09 06:26:03.662002 2016] [:error] [pid 4984] [client 192.168.10.45:43162] PHP Fatal error:  no such method syntax_plugin_data_table in /var/www/gnuwhv/inc/plugin.php on line 298, referer: http://wiki.gnuwhv.priv/start?do=admin&page=extension&tab=plugins&info=data
[Sat Apr 09 06:27:12.590057 2016] [:error] [pid 1528] [client 192.168.10.45:43254] PHP Fatal error:  no such method syntax_plugin_data_table in /var/www/gnuwhv/inc/plugin.php on line 298

Could this be due to a conflict between data plugin and your datatables plugun?

regards, thomas

see also: https://github.com/splitbrain/dokuwiki-plugin-data/issues/194

Klap-in commented 8 years ago

I don't recognize this issue. Do you still get this error if you disable the data plugin or the datatable plugin temporary? Or why do you know that these plugins conflict in some way?

Klap-in commented 8 years ago

The error is thrown at https://github.com/splitbrain/dokuwiki/blob/master/inc/plugin.php#L298

syntax_plugin_data_table is old constructor and is recently renamed. https://github.com/splitbrain/dokuwiki-plugin-data/commit/1971ed3ef529580ee28b7566ca5aeb48b54ffd67

Is it somewhere cached? Can you resave you configuration in the Config manager? That expires caches of DokuWiki itself.

coastgnu commented 8 years ago

I just guessed? hrrmmph, I suspect I'm totally mistaken here...

data_table is not datatables, stupid me

Wer lesen kann ist klar im Vorteil.

pardon me, thomas

coastgnu commented 8 years ago

I put an disabled file to plugins/datatemplate/and voila the whitescreen is gone.

Puhh, ich kann doch lesen... Oder ein Fall von "Blindes Huhn..."

a grep for syntax_plugin_data_table shows: plugins/datatemplate/syntax/list.php:class syntax_plugin_datatemplate_list extends syntax_plugin_data_table { Line 26

Klap-in commented 8 years ago

In the constructor the old constructor name is used, this one should be renamed as well.

https://github.com/ccl/dokuwiki-plugin-datatemplate/blob/master/syntax/list.php#L33

Old: parent::syntax_plugin_data_table();

New: parent::__construct();

Klap-in commented 8 years ago

See also https://github.com/ccl/dokuwiki-plugin-datatemplate/pull/22