search

giterlizzi / dokuwiki-plugin-datatables

Add DataTables support to DokuWiki
GNU General Public License v2.0
10 stars 11 forks source link

possible typo in action.php file #71

Closed BrommD closed 1 year ago

BrommD commented 1 year ago

is this supposed to be correct? image

this issues NOTICE: PHP message: PHP Fatal error: Uncaught Error: Call to undefined function sexplode() in /app/lib/plugins/datatables/action.php:133

removing the s at least removes the error... thx, Dejan

giterlizzi commented 1 year ago

Fixed and updated the plugin version in DokuWiki.org Thanks! ;)

saggi-dw commented 1 year ago

Hi, this is a new function in DokuWiki, not a typo: https://github.com/dokuwiki/dokuwiki/pull/3754

BrommD commented 1 year ago

hi

this means, Dokuwiki should be updated to newest version before applying this plugin update? What about PHP? PHP8 required, too?

thx

saggi-dw commented 1 year ago

this means, Dokuwiki should be updated to newest version before applying this plugin update?

Not at the moment, the change has been reverted (https://github.com/giterlizzi/dokuwiki-plugin-datatables/commit/7e3e0bfcaf746dc4755a1ed19f79fbb4bb9cc91c). I just wanted to let you know that the new DokuWiki release includes this function.