search

giterlizzi / dokuwiki-plugin-datatables

Add DataTables support to DokuWiki
GNU General Public License v2.0
10 stars 11 forks source link

Button and header style doesn't match template #72

Open suedunham opened 1 year ago

suedunham commented 1 year ago

After updating, I noticed that the "Copy", etc. buttons had appeared. I don't need all of them, so I guess that's a prompt to learn how to pare them down. Done.

However, those buttons don't match the style of other buttons on the page. I'm using the bootstrap3 template and bootstrap wrapper, so I expect that this would play nicely with them. For instance, in the Yeti bootswatch theme, the background color looks a bit off, and the datatables buttons have a gradient that is absent in the bootstrap_wrapper ones. The corners are rounded for the former, unlike the latter.

The table headers follow the style of the datatables buttons, which makes sense but is also not what I'm looking for.

As I write this, I see that there's a new version out today. I installed it, and there doesn't seem to be a change, usually. I went into the Configuration Settings and saved it to reset the cache, but refreshing the page normally (F5) doesn't change anything. However, Crtl+F5 makes the buttons and headers look a little better (the button borders are still too dark), but only that key combo works. A plain refresh after that reverts the look to the unmatched style.

The effect is even more jarring in the dark bootswatch themes, where these elements look even more out of place. The font faces of the text do change to match, however.

Ideally, I'd like you to fix this, though I'm not averse to styling these things myself. Please share any tips for suitable css to make the datatables follow the bootstrap wrapper style.

Dokuwiki: 2023-04-04a "Jack Jackrum" Bootstrap3: stable/20220727 Bootstrap Wrapper: 2022-09-22 DataTables: 2023-08-31 Browser: Chrome 116.0.5845.111 PHP: 7.4.30

michielsebastiaan commented 6 months ago

@suedunham Please tell me how you got them away. In the early days we had to add them, nowadays we need to purge them. I have tried things like buttons='' or buttons=false, but they still remain.

Thanks in advance

suedunham commented 6 months ago

@michielsebastiaan I did leave a couple there, using buttons='["copy","csv"]'. Playing around just now, it seems that buttons='[]' does the trick of removing them all.