search

giterlizzi / dokuwiki-template-bootstrap3

Bootstrap-based template for DokuWiki
https://dokuwiki.org/template:bootstrap3
GNU General Public License v2.0
221 stars 77 forks source link

Removal of Fontawesome broke Bootswrapper plugin icons #442

Closed TrapSpace closed 4 years ago

TrapSpace commented 5 years ago

Description

With the removal of Fontawesome in the develop branch, this broke the icons in your Bootswrapper plugin. Since I believe they use Fontawesome form this template.

Steps to reproduce

  1. Install this template from the develop branch
  2. Install Bootswrapper plugin
  3. Add a Callout component with icon=true
  4. You see the Callout component rendered but there is no icon shown

Expected behavior: See an icon in the Callout component

Actual behavior: No icon in the Callout component

Versions

giterlizzi commented 5 years ago

Hi @TrapSpace I have plan to switch to inline SVG icons or force "Icons" plugin dependency for Bootstrap Wrapper Plugin.

I suggest this workaround,

Joseph

giterlizzi/dokuwiki-plugin-bootswrapper#107

TrapSpace commented 5 years ago

Hi @giterlizzi

Thanks for your quick reply and the workaround. I look forward to your next updates.

Cheers

intervisionlord commented 4 years ago

Sad, but this workaround does not work with some elements of wrapper (e.g. buttons). There is no way to make a button with FA icon and text inside it, because icon placed behind button even if the icon code paced inside button container...

giterlizzi commented 4 years ago

In last commit in develop branch, i have re-added the support for FontAwesome4 via Iconify API.

intervisionlord commented 4 years ago

Thank you for your reply. I'll try to check it ASAP.