giterlizzi / dokuwiki-template-bootstrap3

Bootstrap-based template for DokuWiki
https://dokuwiki.org/template:bootstrap3
GNU General Public License v2.0
219 stars 77 forks source link

Heading 1 top margin is reduced after update. How much? #607

Open suedunham opened 7 months ago

suedunham commented 7 months ago

Description

After installing the 2024-02-06 version, The top margin of the heading 1 element at the top of a page has been reduced so that it displays higher on the page. This isn't bad per se, but it does muck up some formatting I had up there, and I'd like to know what accounts for the change.

Steps to reproduce

  1. Screencap a page with a Heading 1 element in a wiki with the previous version of bootstrap3.
  2. Update bootstrap3.
  3. Compare page with screencap.

Expected behavior: I expected no change in the spacing.

Actual behavior: The top margin of the Heading 1 element is reduced.

Versions

Screenshots or Logs

These screencaps were made in a customized template with additional css formatting. This formatting serves to highlight the effect, so I've gone ahead with it. I have confirmed that an unmodified bootstrap3 template exhibits the same behavior.

Before bs3_margin_before

After bs3_margin_after

Note

I'm OK with the change, but I'd like to know what the change was. I assume that a bootstrap3 margin class can be added, where need be. What is prompting this is more page content I've placed above the heading that is now too close.

bs3_margin_icons