Edit mode when not logged in, shows textarea field with source text "as button" (includes fix)

[johngnl]

Description

Edit mode when not logged in, shows textarea field with source text "as button"

Steps to reproduce

1. This happens on a DokuWiki page that a user can read but cannot edit
2. Click on 'Edit' button (or add ?do=edit to the url) to view the source text.
3. The source text will show as a field that is partly formatted as a "success" button</li> </ol> <p><strong>Expected behavior:</strong> As in previous versions of bootstrap 3, the source text should be shown as a grayed out field with all the text shown including newspaces between paragraphs. (See screenshot 2)</p> <p><strong>Actual behavior:</strong> [What actually happened] The complete source text is shown on one line, and the field looks like a green success button when one hovers over it with the mouse pointer. (See screenshot 1)</p> <h3>Versions</h3> <ul> <li>[Bootstrap3 Template] - Template v2024-02-06 (stable/20240206)</li> <li>[DokuWiki] - Release 2024-02-06a "Kaos"</li> <li>[Plugins] - irrelevant</li> <li>[PHP] - 8.2</li> <li>[Browser] - Mozilla Firefox, Chrome, Edge, etc.</li> </ul> <h3>Screenshots or Logs</h3> <p>Screenshot showing issue <strong>before</strong> fix.</p> <p><img referrerpolicy="no-referrer" src="https://github.com/user-attachments/assets/5549b123-4bf6-41f2-83b4-2a420548b6e5" alt="image" /></p> <p>Screenshot <strong>after</strong> fix.</p> <p><img referrerpolicy="no-referrer" src="https://github.com/user-attachments/assets/36a25b4d-b8ed-44c2-9e1c-436102e6c432" alt="image" /></p> <h3>Suggested fix</h3> <p>File is ./lib/tpl/bootstrap3/EventHandlers.php</p> <p><strong>ORIGINAL</strong></p> <pre><code class="language-php">public function formEditOutput(\Doku_Event $event) ... $form->getElementAt($form->findPositionByAttribute('name', 'do[save]')) ->addClass('btn btn-success mr-2')->attr('data-dw-icon', 'mdi:content-save'); $form->getElementAt($form->findPositionByAttribute('name', 'do[preview]')) ->addClass('btn btn-default mr-2')->attr('data-dw-icon', 'mdi:file-document-outline'); $form->getElementAt($form->findPositionByAttribute('name', 'do[cancel]')) ->addClass('btn btn-default mr-2')->attr('data-dw-icon', 'mdi:arrow-left'); ... </code></pre> <p><strong>FIX</strong></p> <pre><code class="language-php">public function formEditOutput(\Doku_Event $event) ... if ($form->findPositionByAttribute('name', 'do[save]') != false) $form->getElementAt($form->findPositionByAttribute('name', 'do[save]')) ->addClass('btn btn-success mr-2')->attr('data-dw-icon', 'mdi:content-save'); if ($form->findPositionByAttribute('name', 'do[preview]') != false) $form->getElementAt($form->findPositionByAttribute('name', 'do[preview]')) ->addClass('btn btn-default mr-2')->attr('data-dw-icon', 'mdi:file-document-outline'); if ($form->findPositionByAttribute('name', 'do[cancel]') != false) $form->getElementAt($form->findPositionByAttribute('name', 'do[cancel]')) ->addClass('btn btn-default mr-2')->attr('data-dw-icon', 'mdi:arrow-left'); ... </code></pre> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>