search

gitevents / core

GitEvents core; manage your user group with GitHub
MIT License
41 stars 19 forks source link

refactor - create or use a module that setus up the milestones #127

Closed iancrowther closed 8 years ago

iancrowther commented 8 years ago

this should be a testable module really

PatrickHeneise commented 8 years ago

that's https://github.com/gitevents/core/blob/master/lib/milestone.js, no?

iancrowther commented 8 years ago

cant npm install that though

PatrickHeneise commented 8 years ago

no, it's a core module. Stuff that's required to run gitevents (web hook, milestones, events, talks) should not be npm modules.

iancrowther commented 8 years ago

Ok

PatrickHeneise commented 8 years ago

Was just thinking if the functionality makes sense to outsource, but since it's just using github npm module which is tested, there's really no need.

iancrowther commented 8 years ago

so I would like to create a module to "setup milestones" anyway, so that UG's that dont want to use gitevents fully, still have a utility belt of helpers. non essential though, nice to have

PatrickHeneise commented 8 years ago

alright. So far I see the milestone setup pretty essential (given the event id is stored in the milestone description and so on). If there's a group who doesn't want to use milestones, we can re-open the issue I guess.

iancrowther commented 8 years ago

Is closed right? No stress