Open TinyExplosions opened 8 years ago
Running on node v5.9.1
and on ubuntu Wily x64 server happens the same.
The problem isn't your setup, the issue is the integration test is using rewire defining a settter for an internal const
defined in lib/event.js:L9
(https://github.com/gitevents/core/blob/b9ca06753308ae0a67c8583b25c1014215ff7128/lib/events.js#L9)
An V8 runtime because protect const vars
reassignation
Not sure why the test passed in the CI and in other dev machines, as I haven't been involved in the development for long time.
I expect that somebody involved recently in the development will provide better explanation and will fix it shortly.
Sorry for the inconveniences and many thanks for reporting it.
Removing 3 lines of test/integration/event.js
L9:L12 should the issue.
I'm not sending a PR because I haven't got pass a few expects of test/integration/talks.js
which may be because I miss to setup something.
there shouldn't be any setup required for the tests. Please submit the PR and I'll continue to investigate as well.
I cloned the gitevents repo, performed an
npm install .
and then rannpm run test
I get the following errors: (npm is version 3.8.3 and node version is 5.4.0). node is being run via nvm.
This is as much for your info as a bug report, as I suspect it could be my setup that's causing the problems! (I'm running OS X 10.11.4, MacBook Pro (Retina, 13-inch, Late 2013))