arxanas commented 2 years ago

I noticed in a large repository that git-stack invocations seem to take a while:

$ time git-stack
master XXXXXXXXXXXX
git-stack  24.36s user 0.69s system 99% cpu 25.064 total

But if I delete master, then it completes immediately:

$ git checkout --detach && git branch -D master
HEAD is now at 548ba95f3c936 XXXXXXXXXXXX
branchless: processing checkout
Deleted branch master (was 548ba95f3c936).
$ time git-stack                               
548ba95 XXXXXXXXXXXX
git-stack  0.04s user 0.01s system 94% cpu 0.051 total

Is there any way to debug what's going on here?

This is on a large repository (500k+ commits) so it's understandable if you don't want to support this use-case.

arxanas commented 2 years ago

I noticed the same happens to a much smaller degree in mozilla/gecko-dev:

$ time git-stack
master no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD
git-stack  2.82s user 0.14s system 99% cpu 2.969 total
$ git checkout --detach && git branch -D master
HEAD is now at 2dc538408a1f no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD
branchless: processing checkout
Deleted branch master (was 2dc538408a1f).
$ time git-stack
2dc5384 no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD
git-stack  0.01s user 0.01s system 89% cpu 0.020 total

Here's the output from git branch -a for gecko-dev, if it's relevant:

Output

``` $ git branch -a * (HEAD detached at 2dc538408a1f) remotes/origin/FIREFOX_ESR_68_0_X_RELBRANCH remotes/origin/FIREFOX_ESR_68_10_X_RELBRANCH remotes/origin/FIREFOX_ESR_68_1_X_RELBRANCH remotes/origin/FIREFOX_ESR_68_2_X_RELBRANCH remotes/origin/FIREFOX_ESR_68_4_X_RELBRANCH remotes/origin/FIREFOX_ESR_68_6_X_RELBRANCH remotes/origin/FIREFOX_ESR_68_8_X_RELBRANCH remotes/origin/FIREFOX_ESR_78_0_X_RELBRANCH remotes/origin/FIREFOX_ESR_78_10_X_RELBRANCH remotes/origin/FIREFOX_ESR_78_3_X_RELBRANCH remotes/origin/FIREFOX_ESR_78_4_X_RELBRANCH remotes/origin/FIREFOX_ESR_78_6_X_RELBRANCH remotes/origin/FIREFOX_ESR_78_7_X_RELBRANCH remotes/origin/FIREFOX_ESR_91_0_X_RELBRANCH remotes/origin/FIREFOX_ESR_91_4_X_RELBRANCH remotes/origin/FIREFOX_ESR_91_5_X_RELBRANCH remotes/origin/FIREFOX_ESR_91_6_X_RELBRANCH remotes/origin/FIREFOX_ESR_91_7_X_RELBRANCH remotes/origin/GECKO1001_2012020805_RELBRANCH remotes/origin/GECKO1002_2012021522_RELBRANCH remotes/origin/GECKO100_2011122113_RELBRANCH remotes/origin/GECKO100_2011122805_RELBRANCH remotes/origin/GECKO100_2012010318_RELBRANCH remotes/origin/GECKO100_2012010410_RELBRANCH remotes/origin/GECKO100_2012011108_RELBRANCH remotes/origin/GECKO100_2012011807_RELBRANCH remotes/origin/GECKO100_2012012323_RELBRANCH remotes/origin/GECKO100_2012012901_RELBRANCH remotes/origin/GECKO110_2012020115_RELBRANCH remotes/origin/GECKO110_2012020801_RELBRANCH remotes/origin/GECKO110_2012021420_RELBRANCH remotes/origin/GECKO110_2012021522_RELBRANCH remotes/origin/GECKO110_2012022207_RELBRANCH remotes/origin/GECKO110_2012022820_RELBRANCH remotes/origin/GECKO110_2012030517_RELBRANCH remotes/origin/GECKO110_2012030815_RELBRANCH remotes/origin/GECKO110_2012030912_RELBRANCH remotes/origin/GECKO110_2012031017_RELBRANCH remotes/origin/GECKO110_2012031218_RELBRANCH remotes/origin/GECKO120_2012031407_RELBRANCH remotes/origin/GECKO120_2012031419_RELBRANCH remotes/origin/GECKO120_2012032021_RELBRANCH remotes/origin/GECKO120_2012032804_RELBRANCH remotes/origin/GECKO120_2012040320_RELBRANCH remotes/origin/GECKO120_2012041106_RELBRANCH remotes/origin/GECKO120_2012041716_RELBRANCH remotes/origin/GECKO120_2012042014_RELBRANCH remotes/origin/GECKO1301_2012061411_RELBRANCH remotes/origin/GECKO1302_2012062310_RELBRANCH remotes/origin/GECKO130_2012042512_RELBRANCH remotes/origin/GECKO130_2012050119_RELBRANCH remotes/origin/GECKO130_2012050817_RELBRANCH remotes/origin/GECKO130_2012051611_RELBRANCH remotes/origin/GECKO130_2012052216_RELBRANCH remotes/origin/GECKO130_2012052311_RELBRANCH remotes/origin/GECKO130_2012052815_RELBRANCH remotes/origin/GECKO130_2012053115_RELBRANCH remotes/origin/GECKO130_2012060104_RELBRANCH remotes/origin/GECKO1401_2012071313_RELBRANCH remotes/origin/GECKO140_2012060421_RELBRANCH remotes/origin/GECKO140_2012060511_RELBRANCH remotes/origin/GECKO140_2012061213_RELBRANCH remotes/origin/GECKO140_2012061216_RELBRANCH remotes/origin/GECKO140_2012061918_RELBRANCH remotes/origin/GECKO140_2012061920_RELBRANCH remotes/origin/GECKO140_2012062401_RELBRANCH remotes/origin/GECKO140_2012062805_RELBRANCH remotes/origin/GECKO140_2012070408_RELBRANCH remotes/origin/GECKO140_2012070409_RELBRANCH remotes/origin/GECKO140_2012071012_RELBRANCH remotes/origin/GECKO140_2012071119_RELBRANCH remotes/origin/GECKO140_2012071314_RELBRANCH remotes/origin/GECKO150_2012071710_RELBRANCH remotes/origin/GECKO150_2012071711_RELBRANCH remotes/origin/GECKO150_2012072419_RELBRANCH remotes/origin/GECKO150_2012073114_RELBRANCH remotes/origin/GECKO150_2012073115_RELBRANCH remotes/origin/GECKO150_2012080812_RELBRANCH remotes/origin/GECKO150_2012080818_RELBRANCH remotes/origin/GECKO150_2012081422_RELBRANCH remotes/origin/GECKO150_2012081508_RELBRANCH remotes/origin/GECKO150_2012082116_RELBRANCH remotes/origin/GECKO150_2012082118_RELBRANCH remotes/origin/GECKO150_2012082415_RELBRANCH remotes/origin/GECKO150_2012082417_RELBRANCH remotes/origin/GECKO1601_2012101014_RELBRANCH remotes/origin/GECKO1602_2012102407_RELBRANCH remotes/origin/GECKO160_2012082808_RELBRANCH remotes/origin/GECKO160_2012082817_RELBRANCH remotes/origin/GECKO160_2012090412_RELBRANCH remotes/origin/GECKO160_2012090515_RELBRANCH remotes/origin/GECKO160_2012091123_RELBRANCH remotes/origin/GECKO160_2012091906_RELBRANCH remotes/origin/GECKO160_2012092515_RELBRANCH remotes/origin/GECKO160_2012092520_RELBRANCH remotes/origin/GECKO160_2012100207_RELBRANCH remotes/origin/GECKO160_2012100209_RELBRANCH remotes/origin/GECKO160_2012100513_RELBRANCH remotes/origin/GECKO160_2012100515_RELBRANCH remotes/origin/GECKO1701_2013010313_RELBRANCH remotes/origin/GECKO170_2012100914_RELBRANCH remotes/origin/GECKO170_2012101014_RELBRANCH remotes/origin/GECKO170_2012101016_RELBRANCH remotes/origin/GECKO170_2012101707_RELBRANCH remotes/origin/GECKO170_2012102312_RELBRANCH remotes/origin/GECKO170_2012103012_RELBRANCH remotes/origin/GECKO170_2012103106_RELBRANCH remotes/origin/GECKO170_2012110619_RELBRANCH remotes/origin/GECKO170_2012111306_RELBRANCH remotes/origin/GECKO170_2012111612_RELBRANCH remotes/origin/GECKO170_2012111918_RELBRANCH remotes/origin/GECKO1801_2013011610_RELBRANCH remotes/origin/GECKO1802_2013020109_RELBRANCH remotes/origin/GECKO180_2012112110_RELBRANCH remotes/origin/GECKO180_2012112808_RELBRANCH remotes/origin/GECKO180_2012112816_RELBRANCH remotes/origin/GECKO180_2012120508_RELBRANCH remotes/origin/GECKO180_2012121210_RELBRANCH remotes/origin/GECKO180_2012121910_RELBRANCH remotes/origin/GECKO180_2012122710_RELBRANCH remotes/origin/GECKO180_2012123109_RELBRANCH remotes/origin/GECKO180_2013010417_RELBRANCH remotes/origin/GECKO1901_2013022619_RELBRANCH remotes/origin/GECKO1902_2013030705_RELBRANCH remotes/origin/GECKO190_2013010812_RELBRANCH remotes/origin/GECKO190_2013010816_RELBRANCH remotes/origin/GECKO190_2013010913_RELBRANCH remotes/origin/GECKO190_2013011610_RELBRANCH remotes/origin/GECKO190_2013011709_RELBRANCH remotes/origin/GECKO190_2013012311_RELBRANCH remotes/origin/GECKO190_2013013010_RELBRANCH remotes/origin/GECKO190_2013020611_RELBRANCH remotes/origin/GECKO190_2013021211_RELBRANCH remotes/origin/GECKO190_2013021515_RELBRANCH remotes/origin/GECKO2001_2013040922_RELBRANCH remotes/origin/GECKO200_2013022008_RELBRANCH remotes/origin/GECKO200_2013022013_RELBRANCH remotes/origin/GECKO200_2013032617_RELBRANCH remotes/origin/GECKO201_2011041321_RELBRANCH remotes/origin/GECKO210_2013050704_RELBRANCH remotes/origin/GECKO210_2013051114_RELBRANCH remotes/origin/GECKO210_2013051217_RELBRANCH remotes/origin/GECKO220_2013061806_RELBRANCH remotes/origin/GECKO220_2013061915_RELBRANCH remotes/origin/GECKO2301_2013081409_RELBRANCH remotes/origin/GECKO2301_2013081518_RELBRANCH remotes/origin/GECKO230_2013073013_RELBRANCH remotes/origin/GECKO230_2013080122_RELBRANCH remotes/origin/GECKO240_2013091018_RELBRANCH remotes/origin/GECKO240esr_2013091022_RELBRANCH remotes/origin/GECKO2411esr_2013111803_RELBRANCH remotes/origin/GECKO2420esr_2013120417_RELBRANCH remotes/origin/GECKO2420esr_2013120520_RELBRANCH remotes/origin/GECKO2430esr_2014012816_RELBRANCH remotes/origin/GECKO2430esr_2014013111_RELBRANCH remotes/origin/GECKO2440esr_2014031511_RELBRANCH remotes/origin/GECKO2450esr_2014042118_RELBRANCH remotes/origin/GECKO2460esr_2014060313_RELBRANCH remotes/origin/GECKO2460esr_2014060920_RELBRANCH remotes/origin/GECKO2470esr_2014071418_RELBRANCH remotes/origin/GECKO2480esr_2014082508_RELBRANCH remotes/origin/GECKO2481esr_2014092322_RELBRANCH remotes/origin/GECKO2501_2013111218_RELBRANCH remotes/origin/GECKO250_2013102121_RELBRANCH remotes/origin/GECKO250_2013102300_RELBRANCH remotes/origin/GECKO250_2013102517_RELBRANCH remotes/origin/GECKO260_2013120223_RELBRANCH remotes/origin/GECKO260_2013120510_RELBRANCH remotes/origin/GECKO2701_2014021215_RELBRANCH remotes/origin/GECKO270_2014012722_RELBRANCH remotes/origin/GECKO280_2014031020_RELBRANCH remotes/origin/GECKO280_2014031500_RELBRANCH remotes/origin/GECKO2901_2014050600_RELBRANCH remotes/origin/GECKO2901_2014050617_RELBRANCH remotes/origin/GECKO290_2014042200_RELBRANCH remotes/origin/GECKO300_2014060316_RELBRANCH remotes/origin/GECKO300_2014060520_RELBRANCH remotes/origin/GECKO310_2014071417_RELBRANCH remotes/origin/GECKO310_2014071621_RELBRANCH remotes/origin/GECKO310esr_2014071418_RELBRANCH remotes/origin/GECKO310esr_2014071715_RELBRANCH remotes/origin/GECKO3110esr_2014082508_RELBRANCH remotes/origin/GECKO3111esr_2014092321_RELBRANCH remotes/origin/GECKO3120esr_2014100702_RELBRANCH remotes/origin/GECKO3120esr_2014101105_RELBRANCH remotes/origin/GECKO3120esr_2014101110_RELBRANCH remotes/origin/GECKO3121esr_2014110314_RELBRANCH remotes/origin/GECKO3130esr_2014112501_RELBRANCH remotes/origin/GECKO3130esr_2014112505_RELBRANCH remotes/origin/GECKO3140esr_2015010523_RELBRANCH remotes/origin/GECKO3150esr_2015021614_RELBRANCH remotes/origin/GECKO3150esr_2015021713_RELBRANCH remotes/origin/GECKO3160esr_2015032414_RELBRANCH remotes/origin/GECKO3160esr_2015032523_RELBRANCH remotes/origin/GECKO3170esr_2015050415_RELBRANCH remotes/origin/GECKO3170esr_2015050422_RELBRANCH remotes/origin/GECKO3180esr_2015062417_RELBRANCH remotes/origin/GECKO3201_2014091023_RELBRANCH remotes/origin/GECKO3201_2014091117_RELBRANCH remotes/origin/GECKO3202_2014091722_RELBRANCH remotes/origin/GECKO3203_2014092320_RELBRANCH remotes/origin/GECKO320_2014082522_RELBRANCH remotes/origin/GECKO330_2014100710_RELBRANCH remotes/origin/GECKO330_2014101104_RELBRANCH remotes/origin/GECKO3311_2014111317_RELBRANCH remotes/origin/GECKO331_2014102917_RELBRANCH remotes/origin/GECKO331_2014103013_RELBRANCH remotes/origin/GECKO331_2014110614_RELBRANCH remotes/origin/GECKO3405_2014112606_RELBRANCH remotes/origin/GECKO340_2014112423_RELBRANCH remotes/origin/GECKO340_2014112520_RELBRANCH remotes/origin/GECKO340_2014112606_RELBRANCH remotes/origin/GECKO3501_2015012300_RELBRANCH remotes/origin/GECKO350_2015010523_RELBRANCH remotes/origin/GECKO350_2015010702_RELBRANCH remotes/origin/GECKO350_2015010823_RELBRANCH remotes/origin/GECKO3601_2015030416_RELBRANCH remotes/origin/GECKO3601_2015030504_RELBRANCH remotes/origin/GECKO3603_2015031922_RELBRANCH remotes/origin/GECKO3604_2015032022_RELBRANCH remotes/origin/GECKO360_2015021920_RELBRANCH remotes/origin/GECKO360_2015022302_RELBRANCH remotes/origin/GECKO3701_2015040222_RELBRANCH remotes/origin/GECKO3702_2015041516_RELBRANCH remotes/origin/GECKO370_2015032422_RELBRANCH remotes/origin/GECKO370_2015032621_RELBRANCH remotes/origin/GECKO3805_2015052119_RELBRANCH remotes/origin/GECKO3805_2015052120_RELBRANCH remotes/origin/GECKO3805_2015052516_RELBRANCH remotes/origin/GECKO3806_2015060512_RELBRANCH remotes/origin/GECKO380_2015050317_RELBRANCH remotes/origin/GECKO380_2015050320_RELBRANCH remotes/origin/GECKO380esr_2015050513_RELBRANCH remotes/origin/GECKO3810esr_2015062417_RELBRANCH remotes/origin/GECKO3810esr_2015070616_RELBRANCH remotes/origin/GECKO3820esr_2015080322_RELBRANCH remotes/origin/GECKO3820esr_2015080613_RELBRANCH remotes/origin/GECKO3830esr_2015091419_RELBRANCH remotes/origin/GECKO3830esr_2015091612_RELBRANCH remotes/origin/GECKO3840esr_2015102712_RELBRANCH remotes/origin/GECKO3840esr_2015102720_RELBRANCH remotes/origin/GECKO3850esr_2015121010_RELBRANCH remotes/origin/GECKO3850esr_2015121418_RELBRANCH remotes/origin/GECKO3851esr_2015121812_RELBRANCH remotes/origin/GECKO3852esr_2015122118_RELBRANCH remotes/origin/GECKO3860esr_2016012100_RELBRANCH remotes/origin/GECKO3870esr_2016030220_RELBRANCH remotes/origin/GECKO3871esr_2016031517_RELBRANCH remotes/origin/GECKO3880esr_2016042017_RELBRANCH remotes/origin/GECKO390_2015062220_RELBRANCH remotes/origin/GECKO390_2015062418_RELBRANCH remotes/origin/GECKO390_2015062614_RELBRANCH remotes/origin/GECKO390_2015063018_RELBRANCH remotes/origin/GECKO4001_2015081122_RELBRANCH remotes/origin/GECKO4002_2015081219_RELBRANCH remotes/origin/GECKO4003_2015082605_RELBRANCH remotes/origin/GECKO400_2015080313_RELBRANCH remotes/origin/GECKO400_2015080415_RELBRANCH remotes/origin/GECKO400_2015080613_RELBRANCH remotes/origin/GECKO400_2015080618_RELBRANCH remotes/origin/GECKO400_2015080711_RELBRANCH remotes/origin/GECKO4101_2015092818_RELBRANCH remotes/origin/GECKO4101_2015092917_RELBRANCH remotes/origin/GECKO4102_2015101322_RELBRANCH remotes/origin/GECKO4102_2015101417_RELBRANCH remotes/origin/GECKO410_2015091421_RELBRANCH remotes/origin/GECKO410_2015091623_RELBRANCH remotes/origin/GECKO410_2015091718_RELBRANCH remotes/origin/GECKO420_2015102619_RELBRANCH remotes/origin/GECKO420_2015102918_RELBRANCH remotes/origin/GECKO4301_2015121620_RELBRANCH remotes/origin/GECKO4302_2015122116_RELBRANCH remotes/origin/GECKO4303_2015122316_RELBRANCH remotes/origin/GECKO4304_2016010417_RELBRANCH remotes/origin/GECKO4304_2016010515_RELBRANCH remotes/origin/GECKO4304_2016010519_RELBRANCH remotes/origin/GECKO430_2015120812_RELBRANCH remotes/origin/GECKO4401_2016020419_RELBRANCH remotes/origin/GECKO4401_2016020518_RELBRANCH remotes/origin/GECKO4402_2016020915_RELBRANCH remotes/origin/GECKO4402_2016020917_RELBRANCH remotes/origin/GECKO4402_2016021018_RELBRANCH remotes/origin/GECKO440_2016011817_RELBRANCH remotes/origin/GECKO440_2016012018_RELBRANCH remotes/origin/GECKO440_2016012318_RELBRANCH remotes/origin/GECKO4501_2016031518_RELBRANCH remotes/origin/GECKO4501esr_2016031518_RELBRANCH remotes/origin/GECKO4501esr_2016031618_RELBRANCH remotes/origin/GECKO4502_2016040719_RELBRANCH remotes/origin/GECKO4502esr_2016041116_RELBRANCH remotes/origin/GECKO450_2016030103_RELBRANCH remotes/origin/GECKO450_2016030316_RELBRANCH remotes/origin/GECKO450esr_2016030316_RELBRANCH remotes/origin/GECKO450esr_2016030414_RELBRANCH remotes/origin/GECKO4510esr_2016042017_RELBRANCH remotes/origin/GECKO4511esr_2016050218_RELBRANCH remotes/origin/GECKO4520esr_2016060214_RELBRANCH remotes/origin/GECKO501_2011070717_RELBRANCH remotes/origin/GECKO50_2011051718_RELBRANCH remotes/origin/GECKO50_2011052708_RELBRANCH remotes/origin/GECKO50_2011060309_RELBRANCH remotes/origin/GECKO50_2011060814_RELBRANCH remotes/origin/GECKO50_2011061316_RELBRANCH remotes/origin/GECKO50_2011061416_RELBRANCH remotes/origin/GECKO50_2011061514_RELBRANCH remotes/origin/GECKO601_2011083006_RELBRANCH remotes/origin/GECKO602_2011083109_RELBRANCH remotes/origin/GECKO60_2011070520_RELBRANCH remotes/origin/GECKO60_2011071316_RELBRANCH remotes/origin/GECKO60_2011072110_RELBRANCH remotes/origin/GECKO60_2011072114_RELBRANCH remotes/origin/GECKO60_2011072907_RELBRANCH remotes/origin/GECKO60_2011080402_RELBRANCH remotes/origin/GECKO60_2011081114_RELBRANCH remotes/origin/GECKO701_2011092812_RELBRANCH remotes/origin/GECKO70_2011081615_RELBRANCH remotes/origin/GECKO70_2011082416_RELBRANCH remotes/origin/GECKO70_2011083009_RELBRANCH remotes/origin/GECKO70_2011083111_RELBRANCH remotes/origin/GECKO70_2011090812_RELBRANCH remotes/origin/GECKO70_2011091608_RELBRANCH remotes/origin/GECKO70_2011092208_RELBRANCH remotes/origin/GECKO80_2011092805_RELBRANCH remotes/origin/GECKO80_2011100518_RELBRANCH remotes/origin/GECKO80_2011101118_RELBRANCH remotes/origin/GECKO80_2011101907_RELBRANCH remotes/origin/GECKO80_2011102619_RELBRANCH remotes/origin/GECKO80_2011103118_RELBRANCH remotes/origin/GECKO80_2011110416_RELBRANCH remotes/origin/GECKO901_2011122016_RELBRANCH remotes/origin/GECKO90_2011110909_RELBRANCH remotes/origin/GECKO90_2011110911_RELBRANCH remotes/origin/GECKO90_2011111609_RELBRANCH remotes/origin/GECKO90_2011112217_RELBRANCH remotes/origin/GECKO90_2011113005_RELBRANCH remotes/origin/GECKO90_2011120622_RELBRANCH remotes/origin/GECKO90_2011121217_RELBRANCH remotes/origin/GECKO90_2011121613_RELBRANCH remotes/origin/HEAD -> origin/master remotes/origin/MOBILE1001_2012020805_RELBRANCH remotes/origin/MOBILE1002_2012021522_RELBRANCH remotes/origin/MOBILE100_2011122112_RELBRANCH remotes/origin/MOBILE100_2011122805_RELBRANCH remotes/origin/MOBILE100_2012010318_RELBRANCH remotes/origin/MOBILE100_2012010410_RELBRANCH remotes/origin/MOBILE100_2012011108_RELBRANCH remotes/origin/MOBILE100_2012011807_RELBRANCH remotes/origin/MOBILE100_2012012323_RELBRANCH remotes/origin/MOBILE100_2012012901_RELBRANCH remotes/origin/MOBILE110_2012020115_RELBRANCH remotes/origin/MOBILE110_2012020801_RELBRANCH remotes/origin/MOBILE110_2012021420_RELBRANCH remotes/origin/MOBILE110_2012021522_RELBRANCH remotes/origin/MOBILE110_2012022207_RELBRANCH remotes/origin/MOBILE110_2012022820_RELBRANCH remotes/origin/MOBILE110_2012030517_RELBRANCH remotes/origin/MOBILE120_2012031407_RELBRANCH remotes/origin/MOBILE120_2012031419_RELBRANCH remotes/origin/MOBILE120_2012032021_RELBRANCH remotes/origin/MOBILE120_2012032804_RELBRANCH remotes/origin/MOBILE120_2012040320_RELBRANCH remotes/origin/MOBILE120_2012041106_RELBRANCH remotes/origin/MOBILE120_2012041716_RELBRANCH remotes/origin/MOBILE130_2012042512_RELBRANCH remotes/origin/MOBILE130_2012042709_RELBRANCH remotes/origin/MOBILE130_2012050119_RELBRANCH remotes/origin/MOBILE130_2012050817_RELBRANCH remotes/origin/MOBILE1401_2012071313_RELBRANCH remotes/origin/MOBILE1401_2012071316_RELBRANCH remotes/origin/MOBILE1402_2012080109_RELBRANCH remotes/origin/MOBILE1402_2012080617_RELBRANCH remotes/origin/MOBILE140_2012060523_RELBRANCH remotes/origin/MOBILE140_2012061216_RELBRANCH remotes/origin/MOBILE140_2012061918_RELBRANCH remotes/origin/MOBILE140_2012062805_RELBRANCH remotes/origin/MOBILE140_2012062810_RELBRANCH remotes/origin/MOBILE140_2012070414_RELBRANCH remotes/origin/MOBILE140_2012071012_RELBRANCH remotes/origin/MOBILE1501_2012090514_RELBRANCH remotes/origin/MOBILE1501_2012090620_RELBRANCH remotes/origin/MOBILE150_2012071710_RELBRANCH remotes/origin/MOBILE150_2012072419_RELBRANCH remotes/origin/MOBILE150_2012073114_RELBRANCH remotes/origin/MOBILE150_2012080812_RELBRANCH remotes/origin/MOBILE150_2012081422_RELBRANCH remotes/origin/MOBILE150_2012082116_RELBRANCH remotes/origin/MOBILE150_2012082314_RELBRANCH remotes/origin/MOBILE150_2012082415_RELBRANCH remotes/origin/MOBILE1601_2012101014_RELBRANCH remotes/origin/MOBILE1602_2012102407_RELBRANCH remotes/origin/MOBILE160_2012082808_RELBRANCH remotes/origin/MOBILE160_2012090412_RELBRANCH remotes/origin/MOBILE160_2012091123_RELBRANCH remotes/origin/MOBILE160_2012091906_RELBRANCH remotes/origin/MOBILE160_2012092520_RELBRANCH remotes/origin/MOBILE160_2012100207_RELBRANCH remotes/origin/MOBILE160_2012100515_RELBRANCH remotes/origin/MOBILE1701_2012112820_RELBRANCH remotes/origin/MOBILE170_2012100914_RELBRANCH remotes/origin/MOBILE170_2012101021_RELBRANCH remotes/origin/MOBILE170_2012101707_RELBRANCH remotes/origin/MOBILE170_2012102312_RELBRANCH remotes/origin/MOBILE170_2012103106_RELBRANCH remotes/origin/MOBILE170_2012110619_RELBRANCH remotes/origin/MOBILE170_2012111306_RELBRANCH remotes/origin/MOBILE170_2012111605_RELBRANCH remotes/origin/MOBILE170_2012111611_RELBRANCH remotes/origin/MOBILE1802_2013020621_RELBRANCH remotes/origin/MOBILE180_2012112113_RELBRANCH remotes/origin/MOBILE180_2012112808_RELBRANCH remotes/origin/MOBILE180_2012120508_RELBRANCH remotes/origin/MOBILE180_2012121210_RELBRANCH remotes/origin/MOBILE180_2012121317_RELBRANCH remotes/origin/MOBILE180_2012121910_RELBRANCH remotes/origin/MOBILE180_2012122710_RELBRANCH remotes/origin/MOBILE180_2012123109_RELBRANCH remotes/origin/MOBILE180_2013010418_RELBRANCH remotes/origin/MOBILE1901_2013030614_RELBRANCH remotes/origin/MOBILE1902_2013030705_RELBRANCH remotes/origin/MOBILE190_2013010812_RELBRANCH remotes/origin/MOBILE190_2013010816_RELBRANCH remotes/origin/MOBILE190_2013011610_RELBRANCH remotes/origin/MOBILE190_2013012311_RELBRANCH remotes/origin/MOBILE190_2013013010_RELBRANCH remotes/origin/MOBILE190_2013020611_RELBRANCH remotes/origin/MOBILE190_2013020621_RELBRANCH remotes/origin/MOBILE190_2013021211_RELBRANCH remotes/origin/MOBILE190_2013021515_RELBRANCH remotes/origin/MOBILE2001_2013041018_RELBRANCH remotes/origin/MOBILE200_2013022008_RELBRANCH remotes/origin/MOBILE200_2013022119_RELBRANCH remotes/origin/MOBILE200_2013022215_RELBRANCH remotes/origin/MOBILE200_2013032617_RELBRANCH remotes/origin/MOBILE210_2013050704_RELBRANCH remotes/origin/MOBILE210_2013050901_RELBRANCH remotes/origin/MOBILE220_2013061806_RELBRANCH remotes/origin/MOBILE230_2013073014_RELBRANCH remotes/origin/MOBILE240_2013091115_RELBRANCH remotes/origin/MOBILE2501_2013111218_RELBRANCH remotes/origin/MOBILE250_2013102121_RELBRANCH remotes/origin/MOBILE250_2013102300_RELBRANCH remotes/origin/MOBILE250_2013102517_RELBRANCH remotes/origin/MOBILE2601_2013121917_RELBRANCH remotes/origin/MOBILE2601_2013121920_RELBRANCH remotes/origin/MOBILE260_2013120223_RELBRANCH remotes/origin/MOBILE260_2013120510_RELBRANCH remotes/origin/MOBILE270_2014012816_RELBRANCH remotes/origin/MOBILE2801_2014032118_RELBRANCH remotes/origin/MOBILE280_2014031500_RELBRANCH remotes/origin/MOBILE2901_2014050600_RELBRANCH remotes/origin/MOBILE290_2014042416_RELBRANCH remotes/origin/MOBILE300_2014060520_RELBRANCH remotes/origin/MOBILE310_2014071714_RELBRANCH remotes/origin/MOBILE3201_2014090921_RELBRANCH remotes/origin/MOBILE3203_2014092320_RELBRANCH remotes/origin/MOBILE320_2014082615_RELBRANCH remotes/origin/MOBILE330_2014100810_RELBRANCH remotes/origin/MOBILE330_2014101104_RELBRANCH remotes/origin/MOBILE331_2014110511_RELBRANCH remotes/origin/MOBILE331_2014110613_RELBRANCH remotes/origin/MOBILE3401_2014121722_RELBRANCH remotes/origin/MOBILE3401_2014121819_RELBRANCH remotes/origin/MOBILE340_2014112423_RELBRANCH remotes/origin/MOBILE340_2014112520_RELBRANCH remotes/origin/MOBILE340_2014112618_RELBRANCH remotes/origin/MOBILE3501_2015020504_RELBRANCH remotes/origin/MOBILE350_2015010823_RELBRANCH remotes/origin/MOBILE3601_2015030417_RELBRANCH remotes/origin/MOBILE3601_2015030509_RELBRANCH remotes/origin/MOBILE3602_2015031211_RELBRANCH remotes/origin/MOBILE3602_2015031403_RELBRANCH remotes/origin/MOBILE3603_2015031922_RELBRANCH remotes/origin/MOBILE3604_2015032022_RELBRANCH remotes/origin/MOBILE360_2015021920_RELBRANCH remotes/origin/MOBILE360_2015022513_RELBRANCH remotes/origin/MOBILE3701_2015040222_RELBRANCH remotes/origin/MOBILE3702_2015041320_RELBRANCH remotes/origin/MOBILE370_2015032520_RELBRANCH remotes/origin/MOBILE3805_2015052804_RELBRANCH remotes/origin/MOBILE3901_2015070520_RELBRANCH remotes/origin/MOBILE3901_2015070622_RELBRANCH remotes/origin/MOBILE3902_2015071316_RELBRANCH remotes/origin/MOBILE390_2015062418_RELBRANCH remotes/origin/MOBILE390_2015062601_RELBRANCH remotes/origin/MOBILE4003_2015082703_RELBRANCH remotes/origin/MOBILE400_2015080510_RELBRANCH remotes/origin/MOBILE4102_2015101322_RELBRANCH remotes/origin/MOBILE4102_2015101417_RELBRANCH remotes/origin/MOBILE410_2015091517_RELBRANCH remotes/origin/MOBILE410_2015091623_RELBRANCH remotes/origin/MOBILE410_2015091718_RELBRANCH remotes/origin/MOBILE4201_2015111905_RELBRANCH remotes/origin/MOBILE4202_2015120112_RELBRANCH remotes/origin/MOBILE420_2015102816_RELBRANCH remotes/origin/MOBILE420_2015102820_RELBRANCH remotes/origin/MOBILE420_2015102905_RELBRANCH remotes/origin/MOBILE4301_2015121519_RELBRANCH remotes/origin/MOBILE430_2015121011_RELBRANCH remotes/origin/MOBILE430_2015121419_RELBRANCH remotes/origin/MOBILE4402_2016020915_RELBRANCH remotes/origin/MOBILE4402_2016020917_RELBRANCH remotes/origin/MOBILE4402_2016020922_RELBRANCH remotes/origin/MOBILE4402_2016021011_RELBRANCH remotes/origin/MOBILE440_2016012018_RELBRANCH remotes/origin/MOBILE4501_2016031519_RELBRANCH remotes/origin/MOBILE4502_2016040719_RELBRANCH remotes/origin/MOBILE450_2016030216_RELBRANCH remotes/origin/MOBILE450_2016030304_RELBRANCH remotes/origin/MOBILE450_2016030316_RELBRANCH remotes/origin/MOBILE4601_2016050218_RELBRANCH remotes/origin/MOBILE460_2016042213_RELBRANCH remotes/origin/MOBILE470_2016060220_RELBRANCH remotes/origin/MOBILE470_2016060422_RELBRANCH remotes/origin/MOBILE4803_2016090208_RELBRANCH remotes/origin/MOBILE480_2016072616_RELBRANCH remotes/origin/MOBILE4902_2016101815_RELBRANCH remotes/origin/MOBILE4902_2016101919_RELBRANCH remotes/origin/MOBILE490_2016090808_RELBRANCH remotes/origin/MOBILE490_2016091217_RELBRANCH remotes/origin/MOBILE490_2016091613_RELBRANCH remotes/origin/MOBILE5001_2016112401_RELBRANCH remotes/origin/MOBILE5002_2016112921_RELBRANCH remotes/origin/MOBILE500_2016110523_RELBRANCH remotes/origin/MOBILE5010_2016120721_RELBRANCH remotes/origin/MOBILE5010_2016120821_RELBRANCH remotes/origin/MOBILE5102_2017020604_RELBRANCH remotes/origin/MOBILE5103_2017020816_RELBRANCH remotes/origin/MOBILE5104_2017021320_RELBRANCH remotes/origin/MOBILE510_2017011707_RELBRANCH remotes/origin/MOBILE510_2017011818_RELBRANCH remotes/origin/MOBILE510_2017011915_RELBRANCH remotes/origin/MOBILE5201_2017031701_RELBRANCH remotes/origin/MOBILE5202_2017032405_RELBRANCH remotes/origin/MOBILE520_2017030210_RELBRANCH remotes/origin/MOBILE520_2017030217_RELBRANCH remotes/origin/MOBILE520_2017030305_RELBRANCH remotes/origin/MOBILE5301_2017041915_RELBRANCH remotes/origin/MOBILE601_2011083008_RELBRANCH remotes/origin/MOBILE602_2011083111_RELBRANCH remotes/origin/MOBILE60_2011071316_RELBRANCH remotes/origin/MOBILE60_2011072110_RELBRANCH remotes/origin/MOBILE60_2011072114_RELBRANCH remotes/origin/MOBILE60_2011072907_RELBRANCH remotes/origin/MOBILE60_2011080402_RELBRANCH remotes/origin/MOBILE60_2011081016_RELBRANCH remotes/origin/MOBILE60_2011081116_RELBRANCH remotes/origin/MOBILE701_2011092812_RELBRANCH remotes/origin/MOBILE70_2011081614_RELBRANCH remotes/origin/MOBILE70_2011082416_RELBRANCH remotes/origin/MOBILE70_2011083009_RELBRANCH remotes/origin/MOBILE70_2011083111_RELBRANCH remotes/origin/MOBILE70_2011090812_RELBRANCH remotes/origin/MOBILE70_2011091608_RELBRANCH remotes/origin/MOBILE70_2011092210_RELBRANCH remotes/origin/MOBILE80_2011092805_RELBRANCH remotes/origin/MOBILE80_2011100517_RELBRANCH remotes/origin/MOBILE80_2011101117_RELBRANCH remotes/origin/MOBILE80_2011101907_RELBRANCH remotes/origin/MOBILE80_2011102618_RELBRANCH remotes/origin/MOBILE80_2011103117_RELBRANCH remotes/origin/MOBILE80_2011110415_RELBRANCH remotes/origin/MOBILE90_2011110909_RELBRANCH remotes/origin/MOBILE90_2011111608_RELBRANCH remotes/origin/MOBILE90_2011112218_RELBRANCH remotes/origin/MOBILE90_2011113006_RELBRANCH remotes/origin/MOBILE90_2011120622_RELBRANCH remotes/origin/MOBILE90_2011121217_RELBRANCH remotes/origin/MOBILE90_2011121612_RELBRANCH remotes/origin/aurora remotes/origin/b2g-inbound remotes/origin/b2g-ota remotes/origin/b2g18 remotes/origin/b2g18_v1_0_0 remotes/origin/b2g18_v1_0_1 remotes/origin/b2g18_v1_1_0_hd remotes/origin/b2g26_v1_2 remotes/origin/b2g26_v1_2f remotes/origin/b2g28_v1_3 remotes/origin/b2g28_v1_3t remotes/origin/b2g30_v1_4 remotes/origin/b2g32_v2_0 remotes/origin/b2g32_v2_0m remotes/origin/b2g34_v2_1 remotes/origin/b2g34_v2_1s remotes/origin/b2g37_v2_2 remotes/origin/b2g37_v2_2r remotes/origin/b2g44_v2_5 remotes/origin/beta remotes/origin/esr17 remotes/origin/esr24 remotes/origin/esr31 remotes/origin/esr38 remotes/origin/esr45 remotes/origin/esr52 remotes/origin/esr60 remotes/origin/esr68 remotes/origin/esr78 remotes/origin/esr91 remotes/origin/fx-team remotes/origin/inbound remotes/origin/loop-ser remotes/origin/master remotes/origin/mozilla-b2g26_v1_2 remotes/origin/release remotes/origin/renovate/configure remotes/origin/tiling ```

I got a flamegraph with cargo flamegraph, but I don't understand why it's doing a revwalk:

(For some reason, Github transformed the .svg into something less interactive, so you can't zoom in on it and read the function names. I took a screenshot of the .svg and uploaded that instead. Let me know if you want the original .svg and I can try to upload it somewhere else.)

epage commented 2 years ago

Thanks for digging into that!

epage commented 2 years ago

We are using revwalk for

Building our commit graph
Calculating distance between commits
Finding parent commits
Getting commits in a range

It seems starting a revwalk is the most expensive step and most of that time comes from forcing it to be a topological sort.

So it seems like if we'd need to avoid a topological sort to make things faster though we'll need these walks to be topological. I assume doing a lot of this ourselves would speed it up.

arxanas commented 2 years ago

What commit graph needs to be built/what distance needs to be calculated/etc. if you have only one branch? I would have figured that would only be necessary if you have multiple branches, or if the local branch tracks a remote branch which is far off (and even then, I wouldn't expect it to take 25s — that's around the time it takes to traverse every commit in the repository, in my memory).

epage commented 2 years ago

if you have only one branch?

We could bypass some of the checks, for example, speeding up distance between HEAD and each protected branch (to find the closest) can easily be optimized by protected_branches.contains(head). However, I decided to leave the code general for now so its easier to reproduce the performance issues so we can optimize it generally and then worry about it in the particular cases afterwards.

What commit graph needs to be built/what distance needs to be calculated/etc. if you have only one branch?

I was also listing every place we use revwalk. The "distance between HEAD and master" was the one taking the most time in my tests. In theory, that should be a trivial revwalk since it should terminate on the first item returned but all of the time is taken up before that first item is returned.

epage commented 2 years ago

Ran the following in the gecko-dev repo

fn walk_noop(_repo: &git2::Repository, _base_id: git2::Oid, _head_id: git2::Oid) -> Vec<git2::Oid> {
    Vec::new()
}

fn walk_custom(repo: &git2::Repository, base_id: git2::Oid, head_id: git2::Oid) -> Vec<git2::Oid> {
    let mut revwalk = repo.revwalk().unwrap();
    revwalk.push(head_id).unwrap();
    revwalk
        .filter_map(Result::ok)
        .take_while(move |oid| *oid != base_id)
        .collect::<Vec<_>>()
}

fn walk_custom_hide(
    repo: &git2::Repository,
    base_id: git2::Oid,
    head_id: git2::Oid,
) -> Vec<git2::Oid> {
    let mut revwalk = repo.revwalk().unwrap();
    revwalk.push(head_id).unwrap();
    revwalk.hide(base_id).unwrap();
    revwalk.filter_map(Result::ok).collect::<Vec<_>>()
}

fn walk_custom_topo(
    repo: &git2::Repository,
    base_id: git2::Oid,
    head_id: git2::Oid,
) -> Vec<git2::Oid> {
    let mut revwalk = repo.revwalk().unwrap();
    revwalk.push(head_id).unwrap();
    revwalk.set_sorting(git2::Sort::TOPOLOGICAL).unwrap();
    revwalk
        .filter_map(Result::ok)
        .take_while(move |oid| *oid != base_id)
        .collect::<Vec<_>>()
}

fn walk_manual(repo: &git2::Repository, base_id: git2::Oid, head_id: git2::Oid) -> Vec<git2::Oid> {
    let mut result = Vec::new();
    let mut queue = std::collections::VecDeque::new();
    queue.push_back(head_id);
    while let Some(next_id) = queue.pop_front() {
        if next_id == base_id {
            continue;
        }

        result.push(next_id);
        let commit = repo.find_commit(next_id).unwrap();
        queue.extend(commit.parent_ids());
    }
    result
}

fn main() {
    let base_id = git2::Oid::from_str("fd583822b7fb236b7dcdac5e7c4dad944b183944").unwrap();
    let head_id = git2::Oid::from_str("327db8421f8bbe94ac26b4a5a68793cf817ad75c").unwrap();
    let mut args = std::env::args().skip(1);
    let name = args.next();
    let algorithm = match name.as_deref() {
        Some("custom") => walk_custom,
        Some("custom_topo") => walk_custom_topo,
        Some("custom_hide") => walk_custom_hide,
        Some("manual") => walk_manual,
        Some(name) => panic!("Unrecognized algorithm `{}`", name),
        None => walk_noop,
    };

    {
        let repo = git2::Repository::discover(".").unwrap();
        let timer = std::time::Instant::now();
        let commits = (algorithm)(&repo, base_id, head_id);
        println!("elapsed: {}us", timer.elapsed().as_micros());
        dbg!(commits);
    }
}

$ cargo run --
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/exp`
elapsed: 0us
[src/main.rs:74] commits = []

$ cargo run -- custom
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/exp custom`
elapsed: 248us
[src/main.rs:74] commits = [
    327db8421f8bbe94ac26b4a5a68793cf817ad75c,
]

$ cargo run -- custom_topo
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/exp custom_topo`
elapsed: 17376063us
[src/main.rs:74] commits = [
    327db8421f8bbe94ac26b4a5a68793cf817ad75c,
]

$ cargo run -- custom_hide
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/exp custom_hide`
elapsed: 557us
[src/main.rs:74] commits = [
    327db8421f8bbe94ac26b4a5a68793cf817ad75c,
]

$ cargo run -- manual
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/exp manual`
elapsed: 114us
[src/main.rs:74] commits = [
    327db8421f8bbe94ac26b4a5a68793cf817ad75c,
]

(multiple runs were done and a representative value was selected for inclusion, except in the topo case)

Granted, these all act slightly differently but one size does not fit all. You rarely need the most expensive option.

epage commented 2 years ago

Also, each algorithm needed to be run in its own process, not just its own git2::Repository, because of caching.

epage commented 2 years ago

203 resolves most cases.

atm we don't support merge-commits and just topologically sort to resolve them. That is the main thing left to see the performance issue go away.

arxanas commented 2 years ago

@epage Thanks for the quick 😉 fix! It works a lot faster now in my repository.

epage commented 2 years ago

Thanks for the feedback as I don't normally get to work with large repos lately.

btw is this just for comparison purposes or is there a way it you are using it in your workflow along with git-branchless? Be curious to know how you might be using them together.

arxanas commented 2 years ago

@epage I figured I'd try it out to manage my interactions with Github. Specifically, I don't have a way of pushing all branches in my current stack, which git stack --push seems to do for me (well, it pushes all of the ready ones, which is fine for me).

epage commented 2 years ago

For more discussion on --push, see

gitext-rs / git-stack

When a protected branch exists, git-stack takes much longer #194

203 resolves most cases.