gitextensions / GitExtensions.GerritPlugin

Git Extensions plugin providing integration with Gerrit Code Review.
MIT License
9 stars 8 forks source link

Error message on Dashboard #63

Open VStark opened 1 year ago

VStark commented 1 year ago

Environment

Issue description

After launch of the Git Extensions application the error message is shown on dashboard (for some reason it pops up twice) image Reference:

Steps to reproduce

Open application. Clean installation.

Expected behavior

There won't be any error

Actual behavior

Stack trace:

File name:   C:\Program Files\Git\bin\git.exe
Arguments:   rev-parse --git-path "hooks"
Working dir: 
Process ID:  21356
Started at:  2023-01-10T09:45:48.9054378+01:00
UI Thread?:  True
Duration:    47,644 ms
Exit code:   GitExtUtils.ExternalOperationException: fatal: not a git repository (or any of the parent directories): .git
 ---> System.Exception: fatal: not a git repository (or any of the parent directories): .git
   --- End of inner exception stack trace ---
   at GitCommands.ExecutableExtensions.GetOutputAsync(IExecutable executable, ArgumentString arguments, Byte[] input, Encoding outputEncoding, CommandCache cache, Boolean stripAnsiEscapeCodes)
   at Microsoft.VisualStudio.Threading.JoinableTask.CompleteOnCurrentThread()
   at Microsoft.VisualStudio.Threading.JoinableTask`1.CompleteOnCurrentThread()
   at Microsoft.VisualStudio.Threading.JoinableTaskFactory.Run[T](Func`1 asyncMethod, JoinableTaskCreationOptions creationOptions)
   at Microsoft.VisualStudio.Threading.JoinableTaskFactory.Run[T](Func`1 asyncMethod)
   at GitCommands.ExecutableExtensions.GetOutput(IExecutable executable, ArgumentString arguments, Byte[] input, Encoding outputEncoding, CommandCache cache, Boolean stripAnsiEscapeCodes)
   at GitCommands.GitModule.ResolveGitInternalPath(String relativePath)
   at GitExtensions.GerritPlugin.GerritPlugin.GetCommitMessageHookPath(IGitModule gitModule)
   at GitExtensions.GerritPlugin.GerritPlugin.HasValidCommitMsgHook(IGitModule gitModule, Boolean force)
   at GitExtensions.GerritPlugin.GerritPlugin.UpdateGerritMenuItems(Object sender, GitUIEventArgs e)
   at GitUI.GitUICommands.InvokeEvent(IWin32Window ownerForm, EventHandler`1 gitUIEventHandler)
Call stack:  not captured

Did this work in previous version of Gerrit plugin?

Yes, When I was using version 3.

Diagnostics

No response

lekhmanrus commented 1 year ago

Hi @VStark, I can't reproduce your error, could you please tell me the Gerrit plugin version? you can find it in the GE Plugin Manager. Thanks!

VStark commented 1 year ago

image Is there something else I can help you with? @lekhmanrus

lekhmanrus commented 1 year ago

I still can't reproduce that. Could you please try GerritPlugin v2.0.4 ?

VStark commented 1 year ago

I have updated GitExtension and I got latest version of this plugin as well and it still behaves as described here.