search

gitextensions / ICSharpCode.TextEditor

ICSharpCode.TextEditor for WinForms
14 stars 22 forks source link

Highlighting vcxproj.filters (xml format) #12

Closed pmiossec closed 5 years ago

pmiossec commented 5 years ago

& adapt how to find Highlighter by extension to support extensions with a '.' inside.

Fixes https://github.com/gitextensions/gitextensions/issues/6471

kbilsted commented 5 years ago

Since you have to make insertions multiple places, perhaps a unit test showing that the extension is correctly matched is a good idea. I'm not thinking a complete coverage, only this new extensions. We can then easily add new extensions in the future

RussKie commented 5 years ago

Since you have to make insertions multiple places, perhaps a unit test showing that the extension is correctly matched is a good idea. I'm not thinking a complete coverage, only this new extensions.

👍 💯

RussKie commented 5 years ago

@kbilsted I'm sure @pmiossec wouldn't protest if you send commits to this PR 😉

pmiossec commented 5 years ago

Test added