search

gitextensions / ICSharpCode.TextEditor

ICSharpCode.TextEditor for WinForms
14 stars 22 forks source link

Text editor not rendering tab character #22

Closed lhiginbotham closed 4 years ago

lhiginbotham commented 4 years ago

Current behaviour

When rewording a commit using Git Extensions, I've found that tab characters are not rendering in the default text editor (though the characters do exist within the commit message and can be seen when doing git log).

Expected behaviour

The text editor should render whitespace whenever there are tab characters in the loaded document.

Steps to reproduce

  1. Go to a commit entry in the commit log in Git Extensions
  2. Right-click the commit entry > Advanced > Reword commit
  3. Edit the text of the commit and notice that adding tabs has no effect on the rendered text. For example, if you have a line with the text "abc" with your cursor between 'a' and 'b', pressing tab 3 times will do nothing, but you will need to press the Delete key 4 times in order to delete the 'a' character. This shows that the tab characters are being processed but just not rendered.

Screenshots

In the text editor, I put a tab between 'w' and 'o' of "Reworded" and a tab between 'm' and 'i' of "commit". image

How it appears in the Git log: image

Did this work in previous version

Not sure

Environment

lhiginbotham commented 4 years ago

@RussKie FYI, the commit entries in Git Extensions does not render tabs either; is this an issue or is it the desired behavior?

RussKie commented 4 years ago

I agree with you. I think it's a bug, I personally can't see this being a desired behaviour in the context of the app.

On Mon, Jun 1, 2020, 10:28 AM Logan Higinbotham notifications@github.com wrote:

@RussKie https://github.com/RussKie FYI, the commit entries in Git Extensions does not render tabs either; is this an issue or is it the desired behavior?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gitextensions/ICSharpCode.TextEditor/issues/22#issuecomment-636555504, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBTEXUZJXX7H2TEO366MYDRULY2TANCNFSM4NPMKPVA .